Re: [RFA] sh-tdep.c: optimize and rename virtual register conversion functions

Elena Zannoni
2004-02-16T15:29:55Z

Corinna Vinschen writes:
> Hi,
>
> the functions sh_sh4_register_convert_to_virtual and
> sh_sh4_register_convert_to_raw are only called once each. In both
> cases, the register numbers are already tested for the correct range,
> before the function is actually called. Therefore it's possible to
> optimize the register number tests away from both functions.
>
> Also, I'd like to propose to rename both functions to get rid of the
> "sh4" in the name. The functions are universal so I'd like to reuse
> them for an upcoming SH variant with different virtual register numbering,
> if that's ok.

Can you elaborate a bit about this new SH variant? Is the test in the
function conflicting with a different test for the new variant?