Re: [RFA] sh-tdep.c: optimize and rename virtual register conversion functions

Elena Zannoni
2004-02-16T16:20:37Z

Corinna Vinschen writes:
> On Feb 16 10:25, Elena Zannoni wrote:
> > Corinna Vinschen writes:
> > > Hi,
> > >
> > > the functions sh_sh4_register_convert_to_virtual and
> > > sh_sh4_register_convert_to_raw are only called once each. In both
> > > cases, the register numbers are already tested for the correct range,
> > > before the function is actually called. Therefore it's possible to
> > > optimize the register number tests away from both functions.
> > >
> > > Also, I'd like to propose to rename both functions to get rid of the
> > > "sh4" in the name. The functions are universal so I'd like to reuse
> > > them for an upcoming SH variant with different virtual register numbering,
> > > if that's ok.
> >
> >
> > Can you elaborate a bit about this new SH variant?
>
> It will introduce a couple of new real registers which requires to
> increment the pseudo double precision register numbers. At the moment
> I can't go into too much detail otherwise.
>
> > Is the test in the
> > function conflicting with a different test for the new variant?
>
> Actually, it was a thinko on my side. The new variant will result
> in incrementing SH_NUM_REGS but when I sent this patch, I was still
> using another register count for this very cpu. Therefore, the
> register test is only superfluous, nothing else. It does not conflict
> with anything.
>
> So, if you think that the test should be kept in that function, that's
> fine with me. The only remaining bit is the naming of the function then.
> The new cpu is not a sh4 type, but it's using the same pseudo register
> functions as the sh4. The function would just not be sh4 specific anymore.

Ok, thanks. Just rename the function for now, we can revisit later.

elena