From: Elena Zannoni <ezannoni@redhat.com>
To: David Carlton <carlton@kealia.com>
Cc: Elena Zannoni <ezannoni@redhat.com>,
gdb-patches <gdb-patches@sources.redhat.com>,
Daniel Jacobowitz <drow@mvista.com>,
Michael Elizabeth Chastain <mec@shout.net>
Subject: Re: [rfa] teach linespec about nested classes
Date: Wed, 11 Feb 2004 15:39:00 -0000 [thread overview]
Message-ID: <16426.19392.847031.448743@localhost.redhat.com> (raw)
In-Reply-To: <yf2vfmebx3a.fsf@hawaii.kealia.com>
David Carlton writes:
> On Mon, 9 Feb 2004 20:11:52 -0500, Elena Zannoni <ezannoni@redhat.com> said:
>
> > The approach looks ok, but, how does the HP related comment fit in
> > with the new code? I know it came in with the HP merge, which is a
> > clue as to its accuracy.... I guess MichaelC found no problems, so
> > it should be ok.
>
> As far as I can tell from that and from other comments elsewhere, HP
> must have been the first people with a C++ compiler that supported
> namespaces and that GDB supported. So some of the namespace-related
> comments look more HP-specific than they were. Also, as far as I can
> tell, HP was generating fully-qualified type names long before we
> were, so that would have led to some differences as well. But now I
> think that the names should look quite similar for DWARF 2 code and HP
> code, so those comments shouldn't be relevant any more.
>
definitely HP were first on a lot of the c++ stuff, yes. And they
changed a lot of decode_lie_1 (now decode_compound).
> I couldn't think of any reason why looking up every intermediate name
> as a class would make any more sense for HP than it would for other
> cases. And, as you say, MichaelC found no problems, which is good.
>
probably their compiler has changed too, in 5+ years (this stuff dates
back to 1997).
> > I have a new version which incorporates the new comments. Does this
> > still work for you?
>
> The functionality is fine, but the comments are a little off (it
> includes the out-of-date HP comments instead of my new ones). How
> about this version? I updated my comments to use the same example
> that you had used.
groan, I missed that. Sure, you can commit this.
next prev parent reply other threads:[~2004-02-11 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m3y8rgngq1.fsf@coconut.kealia.com>
2004-02-10 1:15 ` Elena Zannoni
2004-02-10 18:36 ` David Carlton
2004-02-11 15:39 ` Elena Zannoni [this message]
2004-02-11 18:10 ` David Carlton
2004-02-11 15:23 Michael Elizabeth Chastain
2004-02-11 15:39 ` Elena Zannoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16426.19392.847031.448743@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=carlton@kealia.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=mec@shout.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox