From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7239 invoked by alias); 5 Feb 2004 19:23:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7231 invoked from network); 5 Feb 2004 19:23:12 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 5 Feb 2004 19:23:12 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id 417841A4412; Thu, 5 Feb 2004 14:20:10 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16418.38762.170920.223023@localhost.redhat.com> Date: Thu, 05 Feb 2004 19:23:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] use frame IDs to detect function calls while stepping In-Reply-To: <20040205190115.GA9918@nevyn.them.org> References: <20040205044119.GC18961@gnat.com> <20040205171324.GF18961@gnat.com> <20040205190115.GA9918@nevyn.them.org> X-SW-Source: 2004-02/txt/msg00103.txt.bz2 Daniel Jacobowitz writes: > > + if (IN_SOLIB_CALL_TRAMPOLINE (stop_pc, ecs->stop_func_name)) > > + { > > + /* We landed in a shared library call trampoline, so it > > + is a subroutine call. */ > > + handle_step_into_function (ecs); > > + return; > > + } > > + > > + if (frame_id_eq (get_frame_id (get_prev_frame (get_current_frame ())), > > + step_frame_id)) > > + { > > + /* It's a subroutine call. */ > > + handle_step_into_function (ecs); > > + return; > > + } > > + > > get_prev_frame can return NULL. In fact, it generally does in main. > I don't think it matters, frame_id_eq will handle a comparison with null_frame_id.