From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Ue/lGy+Gsl/vXwAAWB0awg (envelope-from ) for ; Mon, 16 Nov 2020 09:01:19 -0500 Received: by simark.ca (Postfix, from userid 112) id 666A81F08B; Mon, 16 Nov 2020 09:01:19 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 062191E58F for ; Mon, 16 Nov 2020 09:01:19 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A73A63851C24; Mon, 16 Nov 2020 14:01:18 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id C1D9E3851C24 for ; Mon, 16 Nov 2020 14:01:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C1D9E3851C24 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D3006AC23; Mon, 16 Nov 2020 14:01:14 +0000 (UTC) Subject: [PATCH][gdb/testsuite] Fix minimal encodings KPASSes From: Tom de Vries To: Tom Tromey References: <20200930200600.1207702-1-tromey@adacore.com> <87wnz1jf61.fsf@tromey.com> <841f46d8-6f6a-0b89-a99f-6077300e849f@suse.de> Message-ID: <1640fdd0-2d21-1e77-11b5-ccc6fa21afb1@suse.de> Date: Mon, 16 Nov 2020 15:01:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <841f46d8-6f6a-0b89-a99f-6077300e849f@suse.de> Content-Type: multipart/mixed; boundary="------------4DDADC88F574468DF8D01753" Content-Language: en-US X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" This is a multi-part message in MIME format. --------------4DDADC88F574468DF8D01753 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit [ was: Re: [PATCH 0/9] Fix most -fgnat-encodings=minimal failures ] On 11/4/20 5:33 PM, Tom de Vries wrote: > KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: ptype small (PRMS > minimal encodings) > KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print small (PRMS > minimal encodings) > KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print small'first > (PRMS minimal encodings) > KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: ptype multi (PRMS > minimal encodings) > KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print multi (PRMS > minimal encodings) > KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print multi'first > (PRMS minimal encodings) > KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print multi_multi > (PRMS minimal encodings) > KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print > multi_multi(1,3) (PRMS minimal encodings) > KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print > multi_multi(2) (PRMS minimal encodings) > KPASS: gdb.ada/mod_from_name.exp: scenario=minimal: print xp (PRMS > minimal encodings) > KPASS: gdb.ada/pckd_arr_ren.exp: scenario=minimal: print var (PRMS > minimal encodings) > ... Hi, This fixes the KPASSes for me. Any comments? Thanks, - Tom --------------4DDADC88F574468DF8D01753 Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-testsuite-Fix-minimal-encodings-KPASSes.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-gdb-testsuite-Fix-minimal-encodings-KPASSes.patch" [gdb/testsuite] Fix minimal encodings KPASSes With current master I see a couple of KPASSes: ... KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: ptype small \ (PRMS minimal encodings) ... KPASS: gdb.ada/mod_from_name.exp: scenario=minimal: print xp \ (PRMS minimal encodings) KPASS: gdb.ada/pckd_arr_ren.exp: scenario=minimal: print var \ (PRMS minimal encodings) ... The corresponding setup_kfail is called for everything before gnat 11. However, the test-cases also PASS for me with gnat-4.8, gnat-7.5.0 and gnat-8.4.0. Fix the KPASSes by limiting the setup_kfail to gnat 9 and 10. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2020-11-16 Tom de Vries * gdb.ada/enum_idx_packed.exp: Limit setup_kfail to gnat 9 and 10. * gdb.ada/mod_from_name.exp: Same. * gdb.ada/pckd_arr_ren.exp: Same. --- gdb/testsuite/gdb.ada/enum_idx_packed.exp | 5 +++-- gdb/testsuite/gdb.ada/mod_from_name.exp | 5 +++-- gdb/testsuite/gdb.ada/pckd_arr_ren.exp | 5 +++-- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/gdb.ada/enum_idx_packed.exp b/gdb/testsuite/gdb.ada/enum_idx_packed.exp index 2e5a85e76b3..f32c488e171 100644 --- a/gdb/testsuite/gdb.ada/enum_idx_packed.exp +++ b/gdb/testsuite/gdb.ada/enum_idx_packed.exp @@ -28,8 +28,9 @@ foreach_with_prefix scenario {all minimal} { clean_restart ${testfile} - # GNAT >= 11.0 has the needed fix here. - if {$scenario == "minimal" && ![test_compiler_info {gcc-1[1-9]-*}]} { + # GNAT 9 and 10 are known to fail. + if {$scenario == "minimal" && ([test_compiler_info {gcc-9-*}] \ + || [test_compiler_info {gcc-10-*}])} { set old_compiler 1 } else { set old_compiler 0 diff --git a/gdb/testsuite/gdb.ada/mod_from_name.exp b/gdb/testsuite/gdb.ada/mod_from_name.exp index 43d81e0026f..5f779c30845 100644 --- a/gdb/testsuite/gdb.ada/mod_from_name.exp +++ b/gdb/testsuite/gdb.ada/mod_from_name.exp @@ -34,8 +34,9 @@ foreach_with_prefix scenario {all minimal} { return } - # GNAT >= 11.0 has the needed fix here. - if {$scenario == "minimal" && ![test_compiler_info {gcc-1[1-9]-*}]} { + # GNAT 9 and 10 are known to fail. + if {$scenario == "minimal" && ([test_compiler_info {gcc-9-*}] \ + || [test_compiler_info {gcc-10-*}])} { setup_kfail "minimal encodings" *-*-* } gdb_test "print xp" \ diff --git a/gdb/testsuite/gdb.ada/pckd_arr_ren.exp b/gdb/testsuite/gdb.ada/pckd_arr_ren.exp index 13e599b6a58..8c53f857bee 100644 --- a/gdb/testsuite/gdb.ada/pckd_arr_ren.exp +++ b/gdb/testsuite/gdb.ada/pckd_arr_ren.exp @@ -31,8 +31,9 @@ foreach_with_prefix scenario {all minimal} { set bp_location [gdb_get_line_number "STOP" ${testdir}/foo.adb] runto "foo.adb:$bp_location" - # GNAT >= 11.0 has the needed fix here. - if {$scenario == "minimal" && ![test_compiler_info {gcc-1[1-9]-*}]} { + # GNAT 9 and 10 are known to fail. + if {$scenario == "minimal" && ([test_compiler_info {gcc-9-*}] \ + || [test_compiler_info {gcc-10-*}])} { setup_kfail "minimal encodings" *-*-* } gdb_test "print A2" \ --------------4DDADC88F574468DF8D01753--