Re: [PATCH] fix trap in parallel for m32r-sim

Kazuhiro Inaoka
2004-01-16T05:56:53Z

> There's no documentation here that indicates why things are being
> done the way they are.
> If it were my call, I would require more comments.
> i.e. _why_ is "trap || insn" being treated as "insn -> trap".
> This seems like an erroneous thing to do at first glance,
> ergo the need for comments explaining why things are the way they are.
> Does h/w really work that way?
The sequence is the same.
If insn changes SM, IE or C flag, trap will be store wrong value. (rare
case?)

When you use "trap || insn", m32r_trap() is executed before executed insn.
A m32r_trap() uses a result of insn.
ex) trap #2 || ldi r7,#1
What want to do is to execute m32r_trap() after second insn.

> Also, if things are indeed kosher, why the added FIXMEs?
It's meaning this patch is not enough to fix it.
I think it is a first step.

Kazuhiro