Re: [RFA] new test for separate debug info

[Elena Zannoni <ezannoni@redhat.com>]

Michael Elizabeth Chastain writes:
 > I've seen this "unknown debugging format" before, on dwarf-1.
 > I really agree with daniel's idea that the test should be
 > "if format == dwarf-2" rather than "if format != stabs+".
 > 

My idea was more to incrementally add broken cases to the skip list as
we find them. Or one can be in a situation where the test doesn't run
and you don't even know if it really doesn't work. Definitely the
'unknow debugging format' qualifies for skipping.


Index: sepdebug.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/sepdebug.exp,v
retrieving revision 1.1
diff -u -p -r1.1 sepdebug.exp
--- sepdebug.exp        12 Jan 2004 17:20:41 -0000      1.1
+++ sepdebug.exp        13 Jan 2004 23:20:41 -0000
@@ -72,6 +72,10 @@ if { [test_debug_format "stabs"] } then
     # (see dejagnu/lib/framework.exp)
     unsupported "no separate debug info handling with stabs"
     return -1
+} elseif { [test_debug_format "unknown"] } then {
+    # gdb doesn't know what the debug format is. We are out of luck here.
+    unsupported "unknown debugging format"
+    return -1
 }
 gdb_exit
  


 > > Maybe the two unsupported messages should differ a bit more from each
 > > other: "cannot produce separate debug info file" instead?
 > 
 > How about "strip --strip-debug failed", make it really clear.
 > 

Let me think about this, there is also objcopy in the mix. I did try
to have the strip procedure return the error message from strip, so
that it could be displayed, but the message is very long, so I
returned 0 or 1. If you do make check with -v you'll see the real
error.

how is this:


 if [gdb_gnu_strip_debug $binfile] {
-    unsupported "no separate debug info handling"
+    unsupported "cannot produce separate debug info files (check that you have
a recent version of strip and objcopy installed)"
     return -1
 }
  

elena


 > Michael C