From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25878 invoked by alias); 1 Jan 2004 02:43:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25871 invoked from network); 1 Jan 2004 02:43:26 -0000 Received: from unknown (HELO palrel10.hp.com) (156.153.255.245) by sources.redhat.com with SMTP; 1 Jan 2004 02:43:26 -0000 Received: from hplms2.hpl.hp.com (hplms2.hpl.hp.com [15.0.152.33]) by palrel10.hp.com (Postfix) with ESMTP id C218E1C000B9; Wed, 31 Dec 2003 18:43:25 -0800 (PST) Received: from napali.hpl.hp.com (napali.hpl.hp.com [15.4.89.123]) by hplms2.hpl.hp.com (8.12.10/8.12.10/HPL-PA Hub) with ESMTP id i012hOwf018095; Wed, 31 Dec 2003 18:43:25 -0800 (PST) Received: from napali.hpl.hp.com (napali [127.0.0.1]) by napali.hpl.hp.com (8.12.9/8.12.9/Debian-5) with ESMTP id i012hOVR028273; Wed, 31 Dec 2003 18:43:24 -0800 Received: (from davidm@localhost) by napali.hpl.hp.com (8.12.9/8.12.9/Debian-5) id i012hJtu028269; Wed, 31 Dec 2003 18:43:19 -0800 From: David Mosberger MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16371.35143.771388.336283@napali.hpl.hp.com> Date: Thu, 01 Jan 2004 02:43:00 -0000 To: Mark Kettenis Cc: davidm@hpl.hp.com, kevinb@redhat.com, jjohnstn@redhat.com, gdb-patches@sources.redhat.com Subject: Re: make inferior calls work on ia64 even when syscall is pending In-Reply-To: <200312312333.hBVNXNvg016633@elgar.kettenis.dyndns.org> References: <16371.12104.503371.251351@napali.hpl.hp.com> <200312312333.hBVNXNvg016633@elgar.kettenis.dyndns.org> Reply-To: davidm@hpl.hp.com X-URL: http://www.hpl.hp.com/personal/David_Mosberger/ X-SW-Source: 2004-01/txt/msg00002.txt.bz2 >>>>> On Thu, 1 Jan 2004 00:33:23 +0100 (CET), Mark Kettenis said: Mark> If the gdb patch looks OK, please check it in. Mark> David, there are two issues with the patch: Mark> * I suspect that this approach is Linux-specific. If so, you Mark> really shouldn't be adding this bit of code to the generic Mark> ia64_write_pc(). Instead you should create a Linux-specific Mark> ia64_linux_write_pc() and put it in ia64-linux-tdep.c; you'll Mark> probably want to call the generic ia64_write_pc() from there. Mark> Then you must hook in the Linux-specific version if the OSABI Mark> is GDB_OSABI_LINUX. I'm not sure how Linux-specific it really is. I think most Unixish ia64 OSes use r10 as the syscall error flag. I'll leave this one to the gdb experts that know the other ia64 OSes better than I do. Mark> * You should use write_register_pid() instead of Mark> write_register(). Ah, yes, I had the code in ia64_push_dummy_call() and failed to change that when moving it to ia64_write_pc(). --david