From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24556 invoked by alias); 29 Dec 2003 22:32:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24544 invoked from network); 29 Dec 2003 22:32:45 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 29 Dec 2003 22:32:45 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id 89F811A42DB; Mon, 29 Dec 2003 17:32:44 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16368.43916.468843.207711@localhost.redhat.com> Date: Mon, 29 Dec 2003 22:32:00 -0000 To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Patch to imported readline to allow DJGPP build In-Reply-To: <7137-Mon29Dec2003100055+0200-eliz@elta.co.il> References: <7137-Mon29Dec2003100055+0200-eliz@elta.co.il> X-SW-Source: 2003-12/txt/msg00514.txt.bz2 Eli Zaretskii writes: > The current imported readline is broken for DJGPP. The following > patch is needed to allow GDB to build the DJGPP port. Okay to commit? > > Btw, I don't understand what is going on with Readline: I looked at > its official home page (to figure out how to submit the patches below > to the Readline maintainer) and found there an old version 4.3 of > Readline where the DJGPP-specific code is ripped out. The version > that we have in the GDB repository seems a newer one, but it also has > the DJGPP-specific code in it. Can someone please tell me what is the > story behind this? TIA > I remember having exchanged some mail with Chet and you about this, but I don't remember the outcome. I can't find anything in my old mbox either. The readline in our tree includes some patches on top of pure 4.3. One of the patches is this one, which I kept from the previous version: 2000-07-10 Eli Zaretskii * terminal.c (_rl_get_screen_size) [__DJGPP__]: Determine screen size via DJGPP-specific calls. (_rl_init_terminal_io) [__MSDOS__]: DJGPP-specific terminal initialization. (_rl_backspace) [__MSDOS__]: Don't call tputs. (ding) [__MSDOS__]: Use DJGPP-specific calls to support visible bell. * display.c (_rl_move_vert) [__MSDOS__]: Support cursor movement upwards with DJGPP-specific calls. (_rl_clear_to_eol) [__MSDOS__]: Don't call tputs. (_rl_clear_screen) [__MSDOS__]: Support clear-screen with DJGPP-specific calls. (insert_some_chars) [__MSDOS__]: Don't call tputs. (delete_chars) [__MSDOS__]: Don't call tputs. Other changes are those listed in ChangeLog.gdb. You can do a diff with a pristine 4.3 readline. There are some other local changes that I keep integrating at each import. I should probably have specified that in the changelog entry at the time. the files with local changes are: ./aclocal.m4 ./config.h.in ./configure ./configure.in ./display.c ./Makefile.in ./rlmbutil.h ./rltty.c ./shell.c ./signals.c ./terminal.c You changes are OK. I think you should audit the current diffs, though, to see if they are all still needed for DJGPP. On top of that there are some 'official' patches that are advertised on the readline home page, which I have not merged. elena