From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15472 invoked by alias); 5 Dec 2003 00:27:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15459 invoked from network); 5 Dec 2003 00:27:59 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 5 Dec 2003 00:27:59 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id D0EA31A42DB; Thu, 4 Dec 2003 19:27:58 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16335.53518.757219.89681@localhost.redhat.com> Date: Fri, 05 Dec 2003 00:27:00 -0000 To: Joel Brobecker Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA] stabs: remember types that cross reference another type In-Reply-To: <20031205002258.GJ1652@gnat.com> References: <20031031200851.GD1236@gnat.com> <20031103225952.GA2412@gnat.com> <16334.50206.868506.409948@localhost.redhat.com> <20031205002258.GJ1652@gnat.com> X-SW-Source: 2003-12/txt/msg00161.txt.bz2 Joel Brobecker writes: > > Yes, but the comment before that loop you are changing needs some > > revamping. Reading it, it really looks like it is a useless/obsoleted > > thing we are doing here, while now it's not the case anymore. I mean, > > it is useful. > > yes, I agree. I am not sure how much information to keep though. > Would the following be ok? > yep elena > /* If this type has already been declared, then reuse the same type > rather than allocating a new one. This saves some memory. */ > > The current comment is: > > /* Now check to see whether the type has already been > declared. This was written for arrays of cross-referenced > types before we had TYPE_CODE_TARGET_STUBBED, so I'm pretty > sure it is not necessary anymore. But it might be a good > idea, to save a little memory. */ > > -- > Joel