From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25573 invoked by alias); 1 Dec 2003 14:58:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25546 invoked from network); 1 Dec 2003 14:58:09 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 1 Dec 2003 14:58:09 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id BE71F1A42DB; Mon, 1 Dec 2003 09:58:08 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16331.22272.699163.648252@localhost.redhat.com> Date: Mon, 01 Dec 2003 14:58:00 -0000 To: fnf@ninemoons.com Cc: drow@mvista.com (Daniel Jacobowitz), fnf@public.ninemoons.com (Fred Fish), gdb-patches@sources.redhat.com Subject: Re: [PATCH] Outwit compiler dead code elimination in break.exp test In-Reply-To: <200312010045.hB10jRfd009645@fred.ninemoons.com> References: <20031130010728.GA26601@nevyn.them.org> <200312010045.hB10jRfd009645@fred.ninemoons.com> X-SW-Source: 2003-12/txt/msg00006.txt.bz2 Fred Fish writes: > > If you're there, rather than being the second person this month to > > update the line numbers, could you convert it to gdb_get_line_number? > > OK, here is an updated patch. > > -Fred > > 2003-11-29 Fred Fish > > * gdb.base/break.c (globalvar): Add. > (marker1, marker2, marker3, marker4): Set globalvar. > Add additional "set breakpoint NN here" comments. > * gdb.base/condbreak.exp: Use $bp_locationNN variables instead > of hardcoded line numbers. Emit bp_locationNN markers in pass > and fail messages instead of line numbers. Why this? The line numbers were not really hardcoded. > * gdb.base/break.exp: Ditto. > * gdb.base/define.exp: Ditto. > * gdb.base/ena-dis-br.exp: Ditto. > * gdb.base/maint.exp: Ditto. > * gdb.base/until.exp: Ditto. >