From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14323 invoked by alias); 13 Nov 2003 03:08:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14276 invoked from network); 13 Nov 2003 03:08:50 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 13 Nov 2003 03:08:50 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id B75F91A42DC; Wed, 12 Nov 2003 22:08:49 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16306.62913.665489.283514@localhost.redhat.com> Date: Thu, 13 Nov 2003 03:08:00 -0000 To: Michael Snyder Cc: Elena Zannoni , gdb-patches@sources.redhat.com, joern.rennecke@superh.com Subject: Re: [PATCH] Partial de-depricatification of sh64-tdep.c In-Reply-To: <3FB2C83C.8020407@redhat.com> References: <3FB2B2C8.6030105@redhat.com> <16306.47050.950241.719788@localhost.redhat.com> <3FB2C83C.8020407@redhat.com> X-SW-Source: 2003-11/txt/msg00252.txt.bz2 Michael Snyder writes: > Elena Zannoni wrote: > > Michael Snyder writes: > > > This patch gets rid of at least three deprecated functions or macros. > > > I've tested it as well as I can, given that the current sh64 sim > > > doesn't build. This compiles without warnings, and it tests out OK > > > on an older branch that I have in which the sim does build. > > > > please split the indent/formatting changes into a separate patch. > > It's hard to review this. > > Sorry, you're right. Here's the part that isn't comment/whitespace. > I also added a couple lines of ChangeLog that I missed the first time. > > > > 2003-11-12 Michael Snyder > > * sh64-tdep.c: > (sh_sh64_register_raw_size): Delete. > (sh_sh64_register_virtual_size): Delete. > (sh64_extract_return_value): Replace deprecated_store_floating > with store_typed_floating. > (sh_sh64_register_convert_to_raw): Replace > deprecated_store_floating with store_typed_floating. > (sh_sh64_register_virtual_type): Convert to sh64_register_type. > (sh64_frame_chain, sh64_get_saved_pr, sh64_get_saved_register, > sh64_nofp_frame_init_saved_regs, sh64_push_arguments, > sh64_extract_struct_value_address, sh64_pop_frame, > sh64_extract_return_value, sh64_store_return_value, > sh_sh64_register_convert_to_virtual, sh64_pseudo_register_read, > sh_sh64_register_convert_to_raw, sh_pseudo_register_write): > Replace DEPRECATED_REGISTER_RAW_SIZE with register_size. > Replace DEPRECATED_REGISTER_VIRTUAL_TYPE with register_type. > (sh64_gdbarch_init): Don't set deprecated_register_bytes, > deprecated_register_virtual_type, deprecated_register_raw_size, > deprecated_max_register_raw_size, or > deprecated_max_register_virtual_size. Instead, just set > gdbarch_register_type. > looks good. Please apply the indentation changes (if you are running through gdb_indent.sh) separately. elena