From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2468 invoked by alias); 24 Oct 2003 13:16:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2461 invoked from network); 24 Oct 2003 13:16:21 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 24 Oct 2003 13:16:21 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id 9A2361A42EA; Fri, 24 Oct 2003 09:16:47 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16281.9791.565787.650032@localhost.redhat.com> Date: Fri, 24 Oct 2003 13:16:00 -0000 To: "Kris Warkentin" Cc: "Elena Zannoni" , Subject: Re: [Patch] fix for PR:1291 (Ping Corinna) In-Reply-To: <07b401c39415$f4dc7ae0$0202040a@catdog> References: <16240.46973.557418.422147@localhost.redhat.com> <002601c3823a$209cd910$6400a8c0@dash> <07b401c39415$f4dc7ae0$0202040a@catdog> X-SW-Source: 2003-10/txt/msg00723.txt.bz2 Kris Warkentin writes: > Howdy all, > > Finally got around to building a head branch gdb with Corinna's sh4 work. > Excellent job. The backtrace works perfectly now and renders my patch > redundant. Someone can probably put this PR to fixed-test. > Could you still come up with a small testcase to be added to gdb.arch? elena > cheers, > > Kris > > ----- Original Message ----- > From: "Kris Warkentin" > To: "Elena Zannoni" > Cc: > Sent: Tuesday, September 23, 2003 9:21 PM > Subject: Re: [Patch] fix for PR:1291 > > > > > kewarken writes: > > > > Credit to inaba@src.ricoh.co.jp for his original find and patch and > to > > > > Colin Burgess for noting the differences between gcc 2 and 3. > > > > > > > > ChangeLog: > > > > > > > > 2003-09-16 Kris Warkentin > > > > > > > > * sh-tdep.c: Properly detect frame prologues for functions with > > > > more than 256 bytes of local variables. > > > > > > You should give credit to these folks in the changelog entry. > > > > Certainly. > > > > > I wonder if this can be captured in a test case? How does your change > > > interacts with Corinna's rewrite? > > > > I'll take a look at it when I have some more time next week. The test > case > > is very simple so I can easily check to see if Corinna's stuff fixes it. > > Unfortunately my available gdb cycles have been extremely low lately since > > we have a lot of critical internal stuff that I've been grabbed for. > > > > cheers, > > > > Kris > > > > >