From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13356 invoked by alias); 14 Oct 2003 21:41:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13320 invoked from network); 14 Oct 2003 21:41:42 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 14 Oct 2003 21:41:42 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h9ELfgM06910 for ; Tue, 14 Oct 2003 17:41:42 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9ELfgr23004 for ; Tue, 14 Oct 2003 17:41:42 -0400 Received: from localhost.redhat.com (devserv.devel.redhat.com [172.16.58.1]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h9ELffwC022679; Tue, 14 Oct 2003 17:41:41 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id E22CC2CE25; Tue, 14 Oct 2003 17:52:55 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16268.28727.18741.65995@localhost.redhat.com> Date: Tue, 14 Oct 2003 21:41:00 -0000 To: gdb-patches@sources.redhat.com Cc: nickc@redhat.com, rearnsha@arm.com Subject: [PATCH/RFC] coffread.c: delete param X-SW-Source: 2003-10/txt/msg00476.txt.bz2 Based on the discussion in this thread: http://sources.redhat.com/ml/gdb-patches/2003-10/msg00405.html I don't have a set up to test this, though. It does build, that's all I can say. [Richard, Nick, this does affect arm-coff] elena 2003-10-14 Elena Zannoni * coffread.c (coff_symtab_read): Remove passing of info parameter to prim_record_minimal_symbol_and_info. Index: coffread.c =================================================================== RCS file: /cvs/uberbaum/gdb/coffread.c,v retrieving revision 1.45 diff -u -p -r1.45 coffread.c --- coffread.c 21 Sep 2003 01:26:44 -0000 1.45 +++ coffread.c 14 Oct 2003 21:37:31 -0000 @@ -926,15 +926,8 @@ coff_symtab_read (long symtab_offset, un if (cs->c_name[0] != '@' /* Skip tdesc symbols */ ) { struct minimal_symbol *msym; - - /* FIXME: cagney/2001-02-01: The nasty (int) -> (long) - -> (void*) cast is to ensure that that the value of - cs->c_sclass can be correctly stored in a void - pointer in MSYMBOL_INFO. Better solutions - welcome. */ - gdb_assert (sizeof (void *) >= sizeof (cs->c_sclass)); msym = prim_record_minimal_symbol_and_info - (cs->c_name, tmpaddr, ms_type, (void *) (long) cs->c_sclass, + (cs->c_name, tmpaddr, ms_type, NULL, sec, NULL, objfile); if (msym) COFF_MAKE_MSYMBOL_SPECIAL (cs->c_sclass, msym);