From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28728 invoked by alias); 10 Oct 2003 20:14:32 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28718 invoked from network); 10 Oct 2003 20:14:31 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 10 Oct 2003 20:14:31 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h9AKEUM27217 for ; Fri, 10 Oct 2003 16:14:30 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9AKEUc15268 for ; Fri, 10 Oct 2003 16:14:30 -0400 Received: from localhost.redhat.com (devserv.devel.redhat.com [172.16.58.1]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h9AKEU95003539 for ; Fri, 10 Oct 2003 16:14:30 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 906482CCB7; Fri, 10 Oct 2003 16:25:42 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16263.5574.385852.935704@localhost.redhat.com> Date: Fri, 10 Oct 2003 20:14:00 -0000 To: gdb-patches@sources.redhat.com Subject: Re: [RFA] sh-tdep.c: Fix float handling In-Reply-To: <20031010192252.GQ14344@cygbert.vinschen.de> References: <20031004121102.GL11435@cygbert.vinschen.de> <16263.30.584298.427986@localhost.redhat.com> <20031010192252.GQ14344@cygbert.vinschen.de> X-SW-Source: 2003-10/txt/msg00374.txt.bz2 Corinna Vinschen writes: > On Fri, Oct 10, 2003 at 02:53:18PM -0400, Elena Zannoni wrote: > > Please add this expanation as a comment. I find cleared than your > > shorter comments. Just add it before the helper function. > > > > >From here.... > > > > > First, in contrast to non-FPU CPUs, arguments are never split between > > > registers and stack. If an argument doesn't fit in the remaining registers > > > it's always pushed entirely on the stack. My testing led me to the wrong > > > assumption that just types > 16 bytes are pushed entirely on the stack. > > I have a problem with this first part of the comment. This one does > not fit well as a comment to the helper function. I would suggest to > add this (carefully rephrased) to sh_push_dummy_call_fpu(), substituting > the very short > > /* No data is passed partially in registers. */ > Where is that? I think you can add it before the function sh_push_dummy_call_fpu. Or where it makes more sense. I don't care, as long as the whole thing is as clear as possible. It is wasy to understand the code now, but I bet a few months from now we will all have forgotten the details. elena > comment instead. Ok? > > > Since this is a predicate, can you call it sh_treat_as_flt_p . > > Ok. > > > Ok otherwise. > > Thanks, I'd just like to hear about the above comment. > > > BTW, what multilibs are you testing? > > Several, -m2, -m2e, m3e, m4, m4 -ml, -m4-single. > > Corinna > > -- > Corinna Vinschen > Cygwin Developer > Red Hat, Inc.