From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13427 invoked by alias); 10 Oct 2003 01:39:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13415 invoked from network); 10 Oct 2003 01:39:37 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 10 Oct 2003 01:39:37 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h9A1dbM26096 for ; Thu, 9 Oct 2003 21:39:37 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9A1dac19544; Thu, 9 Oct 2003 21:39:36 -0400 Received: from localhost.redhat.com (devserv.devel.redhat.com [172.16.58.1]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h9A1dadT025590; Thu, 9 Oct 2003 21:39:36 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 8B9C32CC88; Thu, 9 Oct 2003 21:50:42 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16262.4209.745127.973168@localhost.redhat.com> Date: Fri, 10 Oct 2003 01:39:00 -0000 To: Michael Snyder Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [PATCH] sh-tdep.c: delete unneeded function. In-Reply-To: <3F85FA02.7020906@redhat.com> References: <16261.46068.56352.920472@localhost.redhat.com> <3F85FA02.7020906@redhat.com> X-SW-Source: 2003-10/txt/msg00344.txt.bz2 Michael Snyder writes: > Elena Zannoni wrote: > > This function is not used for sh, because it is only called for > > targets that have the call dummy location set as ON_STACK. SH uses > > AT_ENTRY_POINT. > > > > elena > > > > > > 2003-10-09 Elena Zannoni > > > > * sh-tdep.c (sh_gdbarch_init): Delete setting of push_dummy_code. > > (sh_gdbarch_init): Delete function, it's only used for dummy calls > > Shouldn't that last be (sh_push_dummy_code):? Grrr, yes, thanks. elena > > > on stack. > > > > Index: sh-tdep.c > > =================================================================== > > RCS file: /cvs/uberbaum/gdb/sh-tdep.c,v > > retrieving revision 1.145 > > diff -u -p -r1.145 sh-tdep.c > > --- sh-tdep.c 3 Oct 2003 08:13:37 -0000 1.145 > > +++ sh-tdep.c 9 Oct 2003 17:36:22 -0000 > > @@ -266,22 +266,6 @@ sh_breakpoint_from_pc (CORE_ADDR *pcptr, > > return breakpoint; > > } > > > > -static CORE_ADDR > > -sh_push_dummy_code (struct gdbarch *gdbarch, > > - CORE_ADDR sp, CORE_ADDR funaddr, int using_gcc, > > - struct value **args, int nargs, > > - struct type *value_type, > > - CORE_ADDR *real_pc, CORE_ADDR *bp_addr) > > -{ > > - /* Allocate space sufficient for a breakpoint. */ > > - sp = (sp - 2) & ~1; > > - /* Store the address of that breakpoint */ > > - *bp_addr = sp; > > - /* sh always starts the call at the callee's entry point. */ > > - *real_pc = funaddr; > > - return sp; > > -} > > - > > /* Prologue looks like > > mov.l r14,@-r15 > > sts.l pr,@-r15 > > @@ -2032,7 +2016,6 @@ sh_gdbarch_init (struct gdbarch_info inf > > set_gdbarch_decr_pc_after_break (gdbarch, 0); > > set_gdbarch_function_start_offset (gdbarch, 0); > > > > - set_gdbarch_push_dummy_code (gdbarch, sh_push_dummy_code); > > set_gdbarch_push_dummy_call (gdbarch, sh_push_dummy_call_nofpu); > > > > set_gdbarch_frame_args_skip (gdbarch, 0); > > >