From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8376 invoked by alias); 9 Oct 2003 22:51:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8325 invoked from network); 9 Oct 2003 22:51:35 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 9 Oct 2003 22:51:35 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h99MpYM18810 for ; Thu, 9 Oct 2003 18:51:34 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h99MpYc10573 for ; Thu, 9 Oct 2003 18:51:34 -0400 Received: from localhost.redhat.com (devserv.devel.redhat.com [172.16.58.1]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h99MpXdT012386; Thu, 9 Oct 2003 18:51:33 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id DFCA02CCB4; Thu, 9 Oct 2003 16:23:12 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16261.50096.713531.701890@localhost.redhat.com> Date: Thu, 09 Oct 2003 22:51:00 -0000 To: vinschen@redhat.com, gdb-patches@sources.redhat.com Subject: Re: [RFA] sh-tdep.c (sh_use_struct_convention): Restructure and fix In-Reply-To: <20031004180852.GA29063@cygbert.vinschen.de> References: <20031004113939.GK11435@cygbert.vinschen.de> <3F7EED21.1060902@redhat.com> <20031004180852.GA29063@cygbert.vinschen.de> X-SW-Source: 2003-10/txt/msg00333.txt.bz2 Corinna Vinschen writes: > On Sat, Oct 04, 2003 at 11:54:09AM -0400, Andrew Cagney wrote: > > > * sh-tdep.c (sh_use_struct_convention): Clean up to have a > > > more readable code. Accomodate 4 byte structs with 4 byte sized > > > first field (e.g. bitfields). > > > > Corinna, > > > > See: http://sources.redhat.com/ml/gdb-patches/2003-10/msg00033.html. > > The ppc64_sysv_return_value code in ppc-sysv-tdep.c, has been written in > > a way that allows a quick update to this new iterface. > > I think my patch is fine. I'm fixing non-deprecated functions to > work better than before. There's nothing wrong with this and I > don't see any gain to use an entirely new technique (2 days old!) > to get probably new errors which I don't have using this method. > > Fixing the bugs is step 1. Converting them to a new technique is > another, later step. Hmm, I think you guys are all getting worked up for nothing, really. Rereading the thread, I think Andrew was referring to a different way to implement this set of ABI related functions, so that it would become easier to do something else that Corinna had posted earlier, namely supporting the Renesas ABI based on the current function, i.e. here: http://sources.redhat.com/ml/gdb-patches/2003-09/msg00524.html To do what needed, we would have to pass the function address as parameter to these sh-tdep.c functions. If we tighten the lot into fewer methods, then there are less things to change. So at this point, what is still unresolved is whether or not somebody is going to do the work, i.e. add an automatic mechanism to detect the abi. If not, what Andrew is suggesting is not a priority. If yes, it will need to be done. And, really, this discussion belongs to the other thread. As far as the change posted in this thread, I'll reply separately. elena > > Corinna > > -- > Corinna Vinschen > Cygwin Developer > Red Hat, Inc.