From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25161 invoked by alias); 8 Oct 2003 16:02:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25154 invoked from network); 8 Oct 2003 16:02:05 -0000 Received: from unknown (HELO sadr.equallogic.com) (66.155.203.134) by sources.redhat.com with SMTP; 8 Oct 2003 16:02:05 -0000 Received: from sadr.equallogic.com (localhost.localdomain [127.0.0.1]) by sadr.equallogic.com (8.12.8/8.12.8) with ESMTP id h98G244j009637 for ; Wed, 8 Oct 2003 12:02:04 -0400 Received: from deneb.dev.equallogic.com (deneb [172.16.1.99]) by sadr.equallogic.com (8.12.8/8.12.8) with ESMTP id h98G24ZA009632; Wed, 8 Oct 2003 12:02:04 -0400 Received: from PKONING.equallogic.com (localhost.localdomain [127.0.0.1]) by deneb.dev.equallogic.com (8.11.6/8.11.6) with ESMTP id h98G23h15738; Wed, 8 Oct 2003 12:02:03 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16260.13563.679000.932331@gargle.gargle.HOWL> Date: Wed, 08 Oct 2003 16:02:00 -0000 From: Paul Koning To: orjan.friberg@axis.com Cc: eliz@elta.co.il, gdb-patches@sources.redhat.com Subject: Re: Display of read/access watchpoints when HAVE_NONSTEPPABLE_WATCHPOINT References: <3F8412C1.8090908@axis.com> X-SW-Source: 2003-10/txt/msg00210.txt.bz2 >>>>> "Orjan" == Orjan Friberg writes: Orjan> Eli Zaretskii wrote: >> Perhaps none of the targets that support hardware read and access >> watchpoints define HAVE_NONSTEPPABLE_WATCHPOINT? Orjan> Yes, that seems to be the case. No; I found that the SB-1 (a MIPS) needs to have this defined. >> Anyway, from your description, it is quite clear that if a target >> defines HAVE_NONSTEPPABLE_WATCHPOINT, GDB must call >> target_stopped_data_address before it disables the watchpoint and >> steps over it, or else the target end should store the necessary >> info somewhere and deliver it when target_stopped_data_address is >> called. Orjan> Right. I was thinking I could make watchpoints "steppable" by Orjan> disabling them in the remote stub when a watchpoint hits, and Orjan> then enabling them again when a continue is issued, but it Orjan> feels like that might create more problems than it solves. Orjan> (For example, watchpoints would never hit when Orjan> single-stepping.) I agree. I ended up defining HAVE_NONSTEPPABLE_WATCHPOINT, and I had to make a patch to deal with the target_stopped_data_address issue you mentioned. (In case someone wonders: this was on a private variant of a 5.3 snapshot; I haven't had enough time to try to submit it as mainstream patches, and parts of what I did appear to be controversial -- such as fixes for the broken shared library handling in that version at least with MIPS NetBSD.) paul