From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1020 invoked by alias); 23 Sep 2003 19:00:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 960 invoked from network); 23 Sep 2003 19:00:01 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 23 Sep 2003 19:00:01 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h8NIxx112776 for ; Tue, 23 Sep 2003 15:00:00 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h8NIxxc22069 for ; Tue, 23 Sep 2003 14:59:59 -0400 Received: from localhost.redhat.com (devserv.devel.redhat.com [172.16.58.1]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h8NIxwRC016596; Tue, 23 Sep 2003 14:59:58 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 6EC0C2CC8A; Tue, 23 Sep 2003 15:09:37 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16240.39537.318052.296725@localhost.redhat.com> Date: Tue, 23 Sep 2003 19:00:00 -0000 To: Jim Ingham Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: Trivial fix to annota1.exp In-Reply-To: References: <1DEB1AE2-E560-11D7-9C6D-00039379E320@apple.com> <16234.3108.137932.914275@localhost.redhat.com> <8A9F7532-EA15-11D7-A429-00039379E320@apple.com> X-SW-Source: 2003-09/txt/msg00499.txt.bz2 Jim Ingham writes: > Oh, yeah, you might want a ChangeLog entry as well: That's what I was after. elena > > 2003-09-18 Jim Ingham > > * annota1.exp: Actually require the presence of the signal > handler > frame in the backtrace for the test testing the presence of the > signal handler frame. > > Jim > On Sep 18, 2003, at 1:20 PM, Jim Ingham wrote: > > > By proper you mean not line-wrapped by Mail.app? > > > > If so, I would be overjoyed to try an attachment: > > > > > > > > If this doesn't make it, I would be slightly depressed to point out > > that the change is 1 character, the "*" after "signal handler > > called.\rnrnrnr)" to a "+". > > > > Jim > > > > On Sep 18, 2003, at 12:48 PM, Elena Zannoni wrote: > > > >> Jim Ingham writes: > >>> I think that the backtrace through a signal handler test in > >>> annota1.exp > >>> is wrong. It uses a "*" in the regexp for the part that is looking > >>> for > >>> the signal handler frame. Because of that, all the test really does > >>> is > >>> count the number of frames, and require they be three or more frames. > >>> It doesn't check that a signal frame is on the stack at all. > >>> > >>> I think you really need a "+" instead, or I don't understand the > >>> point > >>> of the test. > >>> > >>> Is this okay, it still passes on Linux... > >>> > >> > >> I think you are right. I don't think there is any case where we want > >> to pass matching 0 occurrences of that pattern. Would you like to > >> submit a proper patch? > >> > >> elena > >> > >> > >>> Index: annota1.exp > >>> =================================================================== > >>> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota1.exp,v > >>> retrieving revision 1.12 > >>> diff -r1.12 annota1.exp > >>> 299c299 > >>> < -re "frame-begin 0 $hex\r\n#0.*frame-end.*frame-begin 1 > >>> $hex\r\n#1.*(\032\032signal-handler-caller\r\n.signal handler > >>> called.\r\n\r\n)*\032\032frame-end\r\n\r\n\032\032frame-begin 2 > >>> $hex\r\n#2.*(frame-begin 3 $hex\r\n#3.*)*frame-end.*$gdb_prompt$" { > >>> --- > >>>> -re "frame-begin 0 $hex\r\n#0.*frame-end.*frame-begin 1 > >>> $hex\r\n#1.*(\032\032signal-handler-caller\r\n.signal handler > >>> called.\r\n\r\n)+\032\032frame-end\r\n\r\n\032\032frame-begin 2 > >>> $hex\r\n#2.*(frame-begin 3 $hex\r\n#3.*)*frame-end.*$gdb_prompt$" { > >>> > >>> Jim > >>> -- > >>> Jim Ingham jingham@apple.com > >>> Developer Tools > >>> Apple Computer > >>> > > -- > > Jim Ingham jingham@apple.com > > Developer Tools > > Apple Computer > > > > > -- > Jim Ingham jingham@apple.com > Developer Tools > Apple Computer