From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9938 invoked by alias); 18 Sep 2003 19:39:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9920 invoked from network); 18 Sep 2003 19:39:20 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 18 Sep 2003 19:39:20 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h8IJdJ113242 for ; Thu, 18 Sep 2003 15:39:19 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h8IJdIe01292 for ; Thu, 18 Sep 2003 15:39:18 -0400 Received: from localhost.redhat.com (devserv.devel.redhat.com [172.16.58.1]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h8IJdHDM032209 for ; Thu, 18 Sep 2003 15:39:18 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 8FC722CC8F; Thu, 18 Sep 2003 15:48:52 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16234.3108.137932.914275@localhost.redhat.com> Date: Thu, 18 Sep 2003 19:39:00 -0000 To: Jim Ingham Cc: gdb-patches@sources.redhat.com Subject: Re: Trivial fix to annota1.exp In-Reply-To: <1DEB1AE2-E560-11D7-9C6D-00039379E320@apple.com> References: <1DEB1AE2-E560-11D7-9C6D-00039379E320@apple.com> X-SW-Source: 2003-09/txt/msg00400.txt.bz2 Jim Ingham writes: > I think that the backtrace through a signal handler test in annota1.exp > is wrong. It uses a "*" in the regexp for the part that is looking for > the signal handler frame. Because of that, all the test really does is > count the number of frames, and require they be three or more frames. > It doesn't check that a signal frame is on the stack at all. > > I think you really need a "+" instead, or I don't understand the point > of the test. > > Is this okay, it still passes on Linux... > I think you are right. I don't think there is any case where we want to pass matching 0 occurrences of that pattern. Would you like to submit a proper patch? elena > Index: annota1.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota1.exp,v > retrieving revision 1.12 > diff -r1.12 annota1.exp > 299c299 > < -re "frame-begin 0 $hex\r\n#0.*frame-end.*frame-begin 1 > $hex\r\n#1.*(\032\032signal-handler-caller\r\n.signal handler > called.\r\n\r\n)*\032\032frame-end\r\n\r\n\032\032frame-begin 2 > $hex\r\n#2.*(frame-begin 3 $hex\r\n#3.*)*frame-end.*$gdb_prompt$" { > --- > > -re "frame-begin 0 $hex\r\n#0.*frame-end.*frame-begin 1 > $hex\r\n#1.*(\032\032signal-handler-caller\r\n.signal handler > called.\r\n\r\n)+\032\032frame-end\r\n\r\n\032\032frame-begin 2 > $hex\r\n#2.*(frame-begin 3 $hex\r\n#3.*)*frame-end.*$gdb_prompt$" { > > Jim > -- > Jim Ingham jingham@apple.com > Developer Tools > Apple Computer