From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22705 invoked by alias); 16 Sep 2003 15:42:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22650 invoked from network); 16 Sep 2003 15:42:36 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 16 Sep 2003 15:42:36 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h8GFgZ422325 for ; Tue, 16 Sep 2003 11:42:35 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h8GFgYe28114 for ; Tue, 16 Sep 2003 11:42:34 -0400 Received: from localhost.redhat.com (devserv.devel.redhat.com [172.16.58.1]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h8GFgWxI008951; Tue, 16 Sep 2003 11:42:33 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 45F692CA3D; Tue, 16 Sep 2003 09:40:32 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16231.4816.146955.945018@localhost.redhat.com> Date: Tue, 16 Sep 2003 15:42:00 -0000 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com, ac131313@redhat.com, eliz@gnu.org Subject: Re: [PATCH/RFA/RFC] Replecament for DEPRECATED_REG_STRUCT_HAS_ADDR In-Reply-To: <200309141313.h8EDD3um071823@elgar.kettenis.dyndns.org> References: <200309141313.h8EDD3um071823@elgar.kettenis.dyndns.org> X-SW-Source: 2003-09/txt/msg00355.txt.bz2 Mark Kettenis writes: > Here is the promised patch to replace DEPRECATED_REG_STRUCT_HAS_ADDR. > I've baptized the new method stabs_argument_has_addr since that better > describes what it does than the old REG_STRUCT_HAS_ADDR; it's also > used for non-register and non-struct arguments, at least on SPARC. I > also dropped the gcc_p argument since none of the current > implementations of DEPRECATED_REG_STRUCT_HAS_ADDR actually use it. > > Anyway, I moved the type checks that were done in stabsread.c into > default_stabs_argument_has_addr. This means that > stabs_argument_has_addr has to do all type-checks. On SPARC this is > needed to support quad-precision floating-point arguments. > > Andrew, I made stabs_argument_has_addr a multi-arch function, and I > don't provide a macro for it. Is that all-right? I'm a bit confused > when to provide a macro and when not. What are your current ideas > about that? Personally I think we should get rid of the macros and > explicitly use current_gdbarch. > > Eli, are the doc bits OK? > > Mark stabs files changes are ok with me. elena > > Index: ChangeLog > from Mark Kettenis > > * gdbarch.sh (DEPRECATED_REG_STRUCT_HAS_ADDR): Add comment. > (stabs_argument_has_addr): New architecture method. > * arch-utils.h (default_stabs_argument_has_addr): New prototype. > * arch-utils.c: Include "buildsym.h". > (default_stabs_argument_has_addr): New function. > * stabsread.c (define_symbol): Use stabs_argument_has_addr > instead of DEPRECATED_REG_STRUCT_HAS_ADDR. > > Index: doc/ChangeLog > from Mark Kettenis > > * gdbint.texinfo (Target Architecture Definition): Document > pass_argument_by_reference. >