From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8407 invoked by alias); 11 Sep 2003 23:45:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8393 invoked from network); 11 Sep 2003 23:45:14 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 11 Sep 2003 23:45:14 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h8BNjDl19733 for ; Thu, 11 Sep 2003 19:45:13 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h8BNjCe21789 for ; Thu, 11 Sep 2003 19:45:12 -0400 Received: from localhost.redhat.com (devserv.devel.redhat.com [172.16.58.1]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h8BNjBba002947; Thu, 11 Sep 2003 19:45:12 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 420C82CA3D; Thu, 11 Sep 2003 19:54:06 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16225.2845.592851.597277@localhost.redhat.com> Date: Thu, 11 Sep 2003 23:45:00 -0000 To: Andrew Cagney Cc: Jim Blandy , gdb-patches@sources.redhat.com Subject: Re: [patch/rfc;rfa:symtab] Deprecate inside_entry_file In-Reply-To: <3F5F65CB.4070605@redhat.com> References: <3F5E5FDC.5020504@redhat.com> <3F5F65CB.4070605@redhat.com> X-SW-Source: 2003-09/txt/msg00256.txt.bz2 Andrew Cagney writes: > > Andrew Cagney writes: > > > >> Before thinking about committing this I'd like to see comments on the > >> symtab side. > > > > > > The changes in mdebugread.c, dwarfread.c, dwarf2read.c, dbxread.c, and > > coffread.c are just renamings. Was there something more specific that > > you wanted reviewed? > > I wrote: > > > This patch deprecates both the function inside_entry_file() and the object file variables that support it (I don't want there to be any confusion over this :-). > > Are the symtab maintainers ok with this? > > Andrew > In particular note that the function: symfile.c:init_entry_point_info() which sets up all the objfile->ei.deprecated_entry_file* is seriously screwed up for PIE files anyway. In such a case we need to figure out where the program got loaded, just like a shlib, the main executable is not marked as EXEC in the elf header anymore, and lots of other fun stuff. Anyway, the way the entry file/entry point stuff is handled now won't work for PIE. I am currently working on PIE support, BTW. I'll post something as soon as I have some coherent story. elena