From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4765 invoked by alias); 11 Sep 2003 17:16:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4758 invoked from network); 11 Sep 2003 17:16:12 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 11 Sep 2003 17:16:12 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h8BHGAl31178 for ; Thu, 11 Sep 2003 13:16:11 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h8BHGAe16840 for ; Thu, 11 Sep 2003 13:16:10 -0400 Received: from localhost.redhat.com (devserv.devel.redhat.com [172.16.58.1]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h8BHG9ba024613 for ; Thu, 11 Sep 2003 13:16:09 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 2FF842CA3B; Thu, 11 Sep 2003 13:24:57 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16224.45033.39860.763199@localhost.redhat.com> Date: Thu, 11 Sep 2003 17:16:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa/6.0] Fix a thinko in dwarf2loc In-Reply-To: <20030911155039.GA31645@nevyn.them.org> References: <20030801193245.GA2529@nevyn.them.org> <20030817205822.GD11300@nevyn.them.org> <20030824164855.GA17841@nevyn.them.org> <20030907041237.GB10340@nevyn.them.org> <16222.17838.527612.509356@localhost.redhat.com> <20030909212507.GA5686@nevyn.them.org> <16222.23051.280481.102836@localhost.redhat.com> <3F5E5B68.5020902@redhat.com> <20030911155039.GA31645@nevyn.them.org> X-SW-Source: 2003-09/txt/msg00221.txt.bz2 Daniel Jacobowitz writes: > On Tue, Sep 09, 2003 at 06:59:52PM -0400, Andrew Cagney wrote: > > > > > > > > > + return baton.needs_frame || ctx->in_reg; > > > > > > > > > } > > > > > > > > > > > > > > > > > > > Hmmm, the ctx just got freed, you cannot dereference it. Need to use a > > > > > > > > Eek, I'm embarassed. You are so right. > > > > > > > > > local variable. What you are really saying here is that the > > > > > needs_frame variable is not sufficient to describe what's needed. Can > > > > > the case be added, so that needs_frame becomes OK? Proabably you > > > > > need another need_frame_* function. > > > > > > > > No, I can't. The needs_frame_* functions are hooks for things which > > > > are external to the expression evaluator - concepts like "object" and > > > > "thread local storage address" which require information. But the > > > > evaluator won't actually try to read from the register when parsing a > > > > DW_OP_reg1; it just sets in_reg. > > > > > >Oh, ok, I guess save ctx->in_reg in a local variable then. > > > > > >elena > > > > Thanks for picking this up. So there's no confusion I'm also ok with > > this on the branch. > > Thank you both. Checked in. Just for completeness, can you post the patch? thanks elena > > -- > Daniel Jacobowitz > MontaVista Software Debian GNU/Linux Developer