From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26608 invoked by alias); 9 Sep 2003 22:01:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26578 invoked from network); 9 Sep 2003 22:01:24 -0000 Received: from unknown (HELO igw2.watson.ibm.com) (129.34.20.6) by sources.redhat.com with SMTP; 9 Sep 2003 22:01:24 -0000 Received: from sp1n293en1.watson.ibm.com (sp1n293en1.watson.ibm.com [9.2.112.57]) by igw2.watson.ibm.com (8.11.7/8.11.4) with ESMTP id h89LwH7246302; Tue, 9 Sep 2003 17:58:17 -0400 Received: from kitch0.watson.ibm.com (localhost [127.0.0.1]) by sp1n293en1.watson.ibm.com (8.11.7/8.11.7) with ESMTP id h89M1Ah41650; Tue, 9 Sep 2003 18:01:10 -0400 Received: (from jimix@localhost) by kitch0.watson.ibm.com (AIX4.3/8.9.3p2/8.9.3/09-18-2002) id SAA82522; Tue, 9 Sep 2003 18:01:05 -0400 From: Jimi Xenidis MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16222.19873.6535.22360@kitch0.watson.ibm.com> Date: Tue, 09 Sep 2003 22:01:00 -0000 To: Kevin Buettner Cc: Daniel Jacobowitz , gdb-patches@sources.redhat.com, Andrew Cagney Subject: PATCH: Re: AHAH! Re: Patch to eliminate SOFTWARE_SINGLE_STEP In-Reply-To: <1030909175522.ZM21202@localhost.localdomain> References: <3F4398EC.2050405@redhat.com> <16195.39851.78762.619597@kitch0.watson.ibm.com> <3F4440F0.30007@redhat.com> <16198.6133.411978.563514@kitch0.watson.ibm.com> <3F463CA9.5000900@redhat.com> <16198.21410.308896.588372@kitch0.watson.ibm.com> <3F465EFD.9020700@redhat.com> <16220.53590.956496.102996@kitch0.watson.ibm.com> <20030908190016.GB24747@nevyn.them.org> <16220.58287.637563.556990@kitch0.watson.ibm.com> <20030908202005.GA30286@nevyn.them.org> <16220.62220.290008.652878@kitch0.watson.ibm.com> <1030908220107.ZM6208@localhost.localdomain> <16221.61979.434255.784317@kitch0.watson.ibm.com> <1030909161519.ZM20803@localhost.localdomain> <16222.1885.6189.269410@kitch0.watson.ibm.com> <1030909175522.ZM21202@localhost.localdomain> X-SW-Source: 2003-09/txt/msg00180.txt.bz2 >>>>> "KB" == Kevin Buettner writes: KB> For the time being, you can just use ``from_xcoff_exec'' for the KB> test. Please add a comment which indicates that the test ought KB> to be eventually changed to use GDB_OSABI_AIX when it becomes KB> available. (Actually, once things are properly split apart, the KB> test goes away.) You wish is my command and thanks for the help. -JX diff -Naur -X Xdiff src/gdb/ChangeLog mygdb/gdb/ChangeLog --- src/gdb/ChangeLog Tue Sep 9 17:33:08 2003 +++ mygdb/gdb/ChangeLog Tue Sep 9 17:03:52 2003 @@ -1,3 +1,14 @@ +2003-09-09 Jimi Xenidis + + * config/powerpc/tm-ppc-eabi.h: no longer require custion #define of + SOFTWARE_SINGLE_STEP + * config/rs6000/tm-rs6000.h: no longer require custion #define of + SOFTWARE_SINGLE_STEP + * config/powerpc/tm-linux.h: no longer require custion #define of + SOFTWARE_SINGLE_STEP + * rs6000-tdep.c (rs6000_gdbarch_init): Set up software_single_step + while initing gdbarch + 2003-09-09 Ian Lance Taylor * MAINTAINERS: Update my e-mail address. diff -Naur -X Xdiff src/gdb/config/powerpc/tm-linux.h mygdb/gdb/config/powerpc/tm-linux.h --- src/gdb/config/powerpc/tm-linux.h Mon Sep 8 10:06:36 2003 +++ mygdb/gdb/config/powerpc/tm-linux.h Mon Sep 8 10:03:28 2003 @@ -31,12 +31,6 @@ #undef IN_SOLIB_CALL_TRAMPOLINE #undef SKIP_TRAMPOLINE_CODE -/* We can single step on linux */ -#undef SOFTWARE_SINGLE_STEP -#define SOFTWARE_SINGLE_STEP(p,q) internal_error (__FILE__, __LINE__, "Will never execute!") -#undef SOFTWARE_SINGLE_STEP_P -#define SOFTWARE_SINGLE_STEP_P() 0 - /* Make sure nexti gets the help it needs for debugging assembly code without symbols */ diff -Naur -X Xdiff src/gdb/config/powerpc/tm-ppc-eabi.h mygdb/gdb/config/powerpc/tm-ppc-eabi.h --- src/gdb/config/powerpc/tm-ppc-eabi.h Fri Apr 12 15:48:37 2002 +++ mygdb/gdb/config/powerpc/tm-ppc-eabi.h Tue Sep 9 10:54:48 2003 @@ -24,9 +24,6 @@ /* Use generic RS6000 definitions. */ #include "rs6000/tm-rs6000.h" -/* except we want to allow single stepping */ -#undef SOFTWARE_SINGLE_STEP_P -#define SOFTWARE_SINGLE_STEP_P() 0 #undef PROCESS_LINENUMBER_HOOK diff -Naur -X Xdiff src/gdb/config/rs6000/tm-rs6000.h mygdb/gdb/config/rs6000/tm-rs6000.h --- src/gdb/config/rs6000/tm-rs6000.h Mon Sep 8 10:06:36 2003 +++ mygdb/gdb/config/rs6000/tm-rs6000.h Mon Sep 8 10:05:43 2003 @@ -90,12 +90,6 @@ extern CORE_ADDR init_frame_pc_noop (int fromleaf, struct frame_info *prev); #define DEPRECATED_INIT_FRAME_PC(fromleaf, prev) (init_frame_pc_noop (fromleaf, prev)) -/* RS6000/AIX does not support PT_STEP. Has to be simulated. */ - -#define SOFTWARE_SINGLE_STEP_P() 1 -extern void rs6000_software_single_step (enum target_signal, int); -#define SOFTWARE_SINGLE_STEP(sig,bp_p) rs6000_software_single_step (sig, bp_p) - /* Notice when a new child process is started. */ #define TARGET_CREATE_INFERIOR_HOOK rs6000_create_inferior diff -Naur -X Xdiff src/gdb/rs6000-tdep.c mygdb/gdb/rs6000-tdep.c --- src/gdb/rs6000-tdep.c Tue Sep 9 17:33:09 2003 +++ mygdb/gdb/rs6000-tdep.c Tue Sep 9 17:08:02 2003 @@ -3013,6 +3013,16 @@ /* Hook in ABI-specific overrides, if they have been registered. */ gdbarch_init_osabi (info, gdbarch); + if (from_xcoff_exec) + { + /* Note: jimix/2003-06-09: This test should really check for + GDB_OSABI_AIX then that is defined and becomes + available. (Actually, once things are properly split apart, + the test goes away.) */ + /* RS6000/AIX does not support PT_STEP. Has to be simulated. */ + set_gdbarch_software_single_step (gdbarch, rs6000_software_single_step); + } + return gdbarch; }