From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6644 invoked by alias); 6 Aug 2003 06:08:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6630 invoked from network); 6 Aug 2003 06:08:33 -0000 Received: from unknown (HELO neon-gw.transmeta.com) (63.209.4.196) by sources.redhat.com with SMTP; 6 Aug 2003 06:08:33 -0000 Received: (from root@localhost) by neon-gw.transmeta.com (8.9.3/8.9.3) id XAA27969; Tue, 5 Aug 2003 23:08:24 -0700 Received: from mailhost.transmeta.com(10.1.1.15) by neon-gw.transmeta.com via smap (V2.1) id xma027949; Tue, 5 Aug 03 23:07:52 -0700 Received: from casey.transmeta.com (casey.transmeta.com [10.10.25.22]) by deepthought.transmeta.com (8.11.6/8.11.6) with ESMTP id h7667w302435; Tue, 5 Aug 2003 23:07:58 -0700 (PDT) Received: (from dje@localhost) by casey.transmeta.com (8.9.3/8.7.3) id XAA15122; Tue, 5 Aug 2003 23:07:58 -0700 From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16176.39742.145428.442316@casey.transmeta.com> Date: Wed, 06 Aug 2003 06:08:00 -0000 To: "Kei Sakamoto" Cc: "Daniel Jacobowitz" , , newlib@sources.redhat.com Subject: Re: [patch/testcase] gdb.asm/m32r.inc: fix compile error In-Reply-To: <009b01c35bbc$dff15420$5169910a@KEI> References: <028801c35a51$47db96d0$5169910a@KEI> <20030805180235.GA30002@nevyn.them.org> <009b01c35bbc$dff15420$5169910a@KEI> X-SW-Source: 2003-08/txt/msg00077.txt.bz2 Kei Sakamoto writes: > > Two minor things: > > - You accidentally sent a reversed diff. > > - ChangeLog formatting. It should be: > > > > 2003-08-04 Kei Sakamoto > > > > * gdb.asm/m32r.inc: Add several missing symbols. Replace ld24 > > with seth/add3. > > Sorry about that. > > > One less minor thing: no other port needs to declare symbols. It looks > > like part of libc is being dragged in somehow on m32r; could you > > explain why the symbols are necessary? > > asm-source is compiled with -nostartfiles. So gcc does not use libgloss.a. > But on m32r, somehow several system calls, _write, etc., are included > in it. So it is necessary to declare these symbols. On other architectures, > these system calls are included in libc.a, which is not removed > by -nostartfiles. > > Unfortunately, I don't know why m32r's libgloss is different from others. > Should I modify libgloss and newlib rather than declare symbols in m32r.inc? Imagine wanting to use libc in multiple environments, the only difference between them is how the "board support package" works. There isn't necessarily one way that systems in which a particular chip is placed implements system calls (for example). Does one provide separate libc's for each? Or does one factor out the board level issues from libc and keep them separate. This is how newlib+libgloss is intended to work. It doesn't on some targets for various reasons. For some older ports libgloss may not have existed at the time. Thus, IMO, no you don't want to move libgloss into newlib.