From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25530 invoked by alias); 10 Jul 2003 21:21:17 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25520 invoked from network); 10 Jul 2003 21:21:16 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 10 Jul 2003 21:21:16 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id C15572CA3B; Thu, 10 Jul 2003 17:28:19 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16141.55923.596252.107277@localhost.redhat.com> Date: Thu, 10 Jul 2003 21:21:00 -0000 To: Mark Kettenis Cc: Richard Henderson , ezannoni@redhat.com, gdb-patches@gcc.gnu.org Subject: Re: [RFA] Don't SEGV on invalid dwarf2 frame info In-Reply-To: <86wueqp075.fsf@elgar.kettenis.dyndns.org> References: <20030710010318.GA3645@twiddle.net> <86wueqp075.fsf@elgar.kettenis.dyndns.org> X-SW-Source: 2003-07/txt/msg00218.txt.bz2 Mark Kettenis writes: > Richard Henderson writes: > > > Elena, this is the patch I was thinking about. > > > > For the audience, there is at least one bug in current cvs ld's .eh_frame > > optimization code that results in padding being added between sections. > > But we saw similar problems when we added support for .eh_frame generation > > within the assembler (and didn't .align sections), so the discussion in > > the patch is a bit more broad than that. > > > > Does this seem reasonable? > > It does to me. It's unfortunately that this is necessary, but it > makes things more robust, so please check this in. > > Mark As is, the patch doesn't compile. I'll have updated one in a minute. I also think that there should be a check after reading the initial_length, that such length is within the section. In my case, that's where gdb encounters the first bogus value. elena