From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12316 invoked by alias); 23 May 2003 21:53:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12283 invoked from network); 23 May 2003 21:53:37 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 23 May 2003 21:53:37 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h4NLrbH30549 for ; Fri, 23 May 2003 17:53:37 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h4NLrbI28254 for ; Fri, 23 May 2003 17:53:37 -0400 Received: from localhost.redhat.com (IDENT:o+1nsQpeAX0wJi0cjLZciJfubdqghLP1@tooth.toronto.redhat.com [172.16.14.29]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h4NLrao10682 for ; Fri, 23 May 2003 17:53:36 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 6D0CC2C43E; Fri, 23 May 2003 17:59:06 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16078.39338.150780.376217@localhost.redhat.com> Date: Fri, 23 May 2003 21:53:00 -0000 To: gdb-patches@sources.redhat.com Subject: [PATCH] some cleanups in stabsread.c X-SW-Source: 2003-05/txt/msg00469.txt.bz2 These functions should be static. elena 2003-05-23 Elena Zannoni * stabsread.c (dbx_lookup_type): Make static. (read_type): Ditto. (add_undefined_type): Ditto. * stabsread.h (dbx_lookup_type, read_type, add_undefined_type): Do not export. Index: stabsread.h =================================================================== RCS file: /cvs/uberbaum/gdb/stabsread.h,v retrieving revision 1.14 diff -u -p -r1.14 stabsread.h --- stabsread.h 12 Apr 2003 17:41:26 -0000 1.14 +++ stabsread.h 23 May 2003 21:52:21 -0000 @@ -130,15 +130,9 @@ EXTERN int n_this_object_header_files; EXTERN int n_allocated_this_object_header_files; -extern struct type *read_type (char **, struct objfile *); - extern void cleanup_undefined_types (void); -extern struct type **dbx_lookup_type (int[2]); - extern long read_number (char **, int); - -extern void add_undefined_type (struct type *); extern struct symbol *define_symbol (CORE_ADDR, char *, int, int, struct objfile *); Index: stabsread.c =================================================================== RCS file: /cvs/uberbaum/gdb/stabsread.c,v retrieving revision 1.58 diff -u -p -r1.58 stabsread.c --- stabsread.c 14 May 2003 17:43:18 -0000 1.58 +++ stabsread.c 23 May 2003 21:52:35 -0000 @@ -105,6 +105,8 @@ static void fix_common_block (struct sym static int read_type_number (char **, int *); +static struct type *read_type (char **, struct objfile *); + static struct type *read_range_type (char **, int[2], struct objfile *); static struct type *read_sun_builtin_type (char **, int[2], struct objfile *); @@ -146,6 +148,8 @@ static struct type *read_array_type (cha static struct field *read_args (char **, int, struct objfile *, int *, int *); +static void add_undefined_type (struct type *); + static int read_cpp_abbrev (struct field_info *, char **, struct type *, struct objfile *); @@ -248,7 +252,7 @@ static struct symbol *current_symbol = N This can be used for finding the type associated with that pair or for associating a new type with the pair. */ -struct type ** +static struct type ** dbx_lookup_type (int typenums[2]) { register int filenum = typenums[0]; @@ -2259,7 +2263,7 @@ error_type (char **pp, struct objfile *o assume that type information starts with a digit, '-', or '(' in deciding whether to call read_type. */ -struct type * +static struct type * read_type (register char **pp, struct objfile *objfile) { register struct type *type = 0; @@ -5128,7 +5132,7 @@ fix_common_block (struct symbol *sym, in /* Add a type to the list of undefined types to be checked through once this file has been read in. */ -void +static void add_undefined_type (struct type *type) { if (undef_types_length == undef_types_allocated)