From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9538 invoked by alias); 19 May 2003 17:09:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9460 invoked from network); 19 May 2003 17:09:50 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 19 May 2003 17:09:50 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h4JH9oH31586 for ; Mon, 19 May 2003 13:09:50 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h4JH9nI27717 for ; Mon, 19 May 2003 13:09:49 -0400 Received: from localhost.redhat.com (IDENT:aZseIkOGXlQvimXGbvHco3keVrLZLbRg@tooth.toronto.redhat.com [172.16.14.29]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h4JH9no23957 for ; Mon, 19 May 2003 13:09:49 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 5759E2C43C; Mon, 19 May 2003 13:15:09 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16073.4381.152225.216887@localhost.redhat.com> Date: Mon, 19 May 2003 17:09:00 -0000 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH/i386newframe] Fix amd64 stack frame base address In-Reply-To: <200305191659.h4JGxcio001173@elgar.kettenis.dyndns.org> References: <200305191659.h4JGxcio001173@elgar.kettenis.dyndns.org> X-SW-Source: 2003-05/txt/msg00340.txt.bz2 Mark Kettenis writes: > This makes the DWARF CFI and amd64 unwinders agree on what's the base > of the stack frame. > > Comitted. thanks! this fixes the assertion failure I was seeing. Running the testsuite right now. elena > > Mark > > > Index: ChangeLog > from Mark Kettenis > > * x86-64-tdep.c (x86_64_frame_this_id, > x86_64_sigtramp_frame_this_id, x86_64_unwind_dummy_id): Add offset > to the frame base such that we use the same defenition for the top > of stack as DWARF CFI does. > > Index: x86-64-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/x86-64-tdep.c,v > retrieving revision 1.67.2.4 > diff -u -p -r1.67.2.4 x86-64-tdep.c > --- x86-64-tdep.c 18 May 2003 17:57:00 -0000 1.67.2.4 > +++ x86-64-tdep.c 19 May 2003 16:57:10 -0000 > @@ -966,7 +966,7 @@ x86_64_frame_this_id (struct frame_info > if (inside_entry_file (cache->pc)) > return; > > - (*this_id) = frame_id_build (cache->base, cache->pc); > + (*this_id) = frame_id_build (cache->base + 16, cache->pc); > } > > static void > @@ -1064,7 +1064,7 @@ x86_64_sigtramp_frame_this_id (struct fr > struct x86_64_frame_cache *cache = > x86_64_sigtramp_frame_cache (next_frame, this_cache); > > - (*this_id) = frame_id_build (cache->base, frame_pc_unwind (next_frame)); > + (*this_id) = frame_id_build (cache->base + 16, frame_pc_unwind (next_frame)); > } > > static void > @@ -1133,7 +1133,7 @@ x86_64_unwind_dummy_id (struct gdbarch * > frame_unwind_register (next_frame, X86_64_RBP_REGNUM, buf); > fp = extract_unsigned_integer (buf, 8); > > - return frame_id_build (fp, frame_pc_unwind (next_frame)); > + return frame_id_build (fp + 16, frame_pc_unwind (next_frame)); > } > > void