From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6054 invoked by alias); 15 May 2003 22:00:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6014 invoked from network); 15 May 2003 22:00:34 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 15 May 2003 22:00:34 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h4FM0YH08174 for ; Thu, 15 May 2003 18:00:34 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h4FM0YI13334 for ; Thu, 15 May 2003 18:00:34 -0400 Received: from localhost.redhat.com (IDENT:tWStiwhObNF8+HDvvv2JeqhVa+fN76t7@tooth.toronto.redhat.com [172.16.14.29]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h4FM0WQ02193; Thu, 15 May 2003 18:00:32 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 2B8A52C950; Thu, 15 May 2003 18:05:48 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16068.3900.457800.96561@localhost.redhat.com> Date: Thu, 15 May 2003 22:00:00 -0000 To: Mark Kettenis Cc: roland@redhat.com, gdb-patches@sources.redhat.com Subject: Re: [branch patch] dwarf-frame.c support for .eh_frame_hdr In-Reply-To: <200305152149.h4FLnGHK000471@elgar.kettenis.dyndns.org> References: <200305120946.h4C9ksj17912@magilla.sf.frob.com> <200305152149.h4FLnGHK000471@elgar.kettenis.dyndns.org> X-SW-Source: 2003-05/txt/msg00260.txt.bz2 Mark Kettenis writes: > Date: Mon, 12 May 2003 02:46:54 -0700 > From: Roland McGrath > > 2003-05-12 Roland McGrath > > * dwarf2read.c (dwarf_eh_frame_hdr_offset, dwarf_eh_frame_hdr_size, > dwarf_eh_frame_hdr_section): New variables. > (dwarf2_locate_sections): Match a section whose name starts with > "eh_frame_hdr", and set those. > (dwarf2_has_info): Clear dwarf_eh_frame_hdr_offset here. > * dwarf-frame.c (decode_eh_frame_hdr): New function. > (dwarf2_build_frame_info): Call it when dwarf_eh_frame_hdr_offset > is set but dwarf_eh_frame_offset is not. > > Having to build a "dummy" `struct comp_unit' probably indicates that I > should change read_encoded_value()'s signature. Well, I'll worry > about that later. > > The error messages in dwarf-frame.c should probably be harmonized > before we check merge this into mailine. I wonder whether we should > complaint() instead of error(). > > Is there a particular reason why you don't read in the .eh_frame_hdr > section as a whole as the other parts of GDB's "symbol reader" do (and > which I just blindly copied when I wrote the guts of dwarf-frame.c)? > > * symfile.c (symfile_bfd_open): Try bfd_check_format with bfd_core > if bfd_object fails. > > I think a more elaborate comment on why core files might have > "symbols" is appropriate. > Did we settle on this being the solution though? I think the /proc/PID/auxv approach is a bit cleaner. Not to say that there aren't things here that are probably necessary anyway, but the debate is still ongoing. elena > Mark