Re: [RFA] Add TYPE_CODE_FIXED_POINT handling in print_type_scalar

Simon Marchi
2020-11-22T14:36:05Z

On 2020-11-22 8:12 a.m., Joel Brobecker wrote:
> Hello,
>
> This commit enhances print_type_scalar to include support for
> TYPE_CODE_FIXED_POINT. This way, any language falling back to
> this function for printing the description of some types
> also gets basic ptype support for fixed point types as well.
>
> This fixes a couple of XFAILs in gdb.dwarf2/dw2-fixed-point.exp.
>
> gdb/ChangeLog:
>
> * typeprint.c (print_type_scalar): Add handling of
> TYPE_CODE_FIXED_POINT.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.dwarf2/dw2-fixed-point.exp: Fix the expected output of
> the "ptype pck__fp1_range_var" test for the module-2 and pascal
> languages. Remove the associated setup_xfail.
>
> The ptype output for range types in modula-2 and pascal is a little
> odd (the type info is repeated twice around the ".." operator), but
> I guess that's how they present range types in those languages.

Yeah, it seems like it. Thanks for doing this, the change to handle
fixed point in the generic print_type_scalar function looks good to me.

Simon