From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14567 invoked by alias); 21 Apr 2003 16:26:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14513 invoked from network); 21 Apr 2003 16:26:35 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 21 Apr 2003 16:26:35 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h3LGQYD19995 for ; Mon, 21 Apr 2003 12:26:34 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h3LGQYq23404; Mon, 21 Apr 2003 12:26:34 -0400 Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h3LGQQb10031; Mon, 21 Apr 2003 12:26:27 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 62F0F2C438; Mon, 21 Apr 2003 12:31:00 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16036.7363.908440.428459@localhost.redhat.com> Date: Mon, 21 Apr 2003 16:26:00 -0000 To: fedor@doc.com Cc: drow@mvista.com, Elena Zannoni , Michael Snyder , GDB Patches Subject: Re: [PATCH] Handle ObjC OPS in eval.c In-Reply-To: <20030421041353.GA18918@nevyn.them.org> References: <3E15F21B.6010101@doc.com> <3E39E887.AB98ECA4@redhat.com> <3E4B195D.2000200@doc.com> <15955.58501.106665.997721@localhost.redhat.com> <3E6585AA.7040602@doc.com> <16021.59784.477170.598470@localhost.redhat.com> <3EA21739.2030403@doc.com> <20030421041353.GA18918@nevyn.them.org> X-SW-Source: 2003-04/txt/msg00368.txt.bz2 Daniel Jacobowitz writes: > On Sat, Apr 19, 2003 at 09:42:49PM -0600, Adam Fedor wrote: > > > > > > Elena Zannoni wrote: > > >Adam Fedor writes: > > > > > > > > > > > > Elena Zannoni wrote: > > > > [...] > > > > > > > > > > I think we need more comments, I guess stret means structure return? > > > > > What are these methods used for? Also can you add a high level > > > > > description of how these dispatchers get into the picture? > > > > > > > > > > > > > Here's a better documented and slightly cleaned-up patch. > > > > 2003-03-04 Adam Fedor > > > > > >I think it's ok. Except I don't like to introduce more #if0 code with new > > >code. > > >Do we really need that part? > > > > > > > I bet no one would complain if I took it out. > > > > The larger problem I have, though, is changing the patch so that I can > > call the objc-lang functions indirectly, so that objc-lang.o does not > > have to be linked in. That seems like a pain. > > > > I think it would be easier to split objc-lang.c into two parts. One that > > is architecture independant that I could link in now, and the other > > acitecture dependant part (which is already handled via the language > > vector). Anything wrong with that? > > What would go in the architecture dependant part? That shouldn't > involve te _language_ vector, it should involve the _gdbarch_ vector, > and go in the already-existing arch files. I think. > Yes, I don't think I understand what you mean by splitting objc-lang.c in two parts. elena > -- > Daniel Jacobowitz > MontaVista Software Debian GNU/Linux Developer