From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10085 invoked by alias); 15 Apr 2003 02:26:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10039 invoked from network); 15 Apr 2003 02:25:50 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 15 Apr 2003 02:25:50 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h3F2PoD04462 for ; Mon, 14 Apr 2003 22:25:50 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h3F2Pnq01933 for ; Mon, 14 Apr 2003 22:25:49 -0400 Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h3F2Pm227660; Mon, 14 Apr 2003 22:25:48 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id C622B2C444; Mon, 14 Apr 2003 22:30:11 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16027.28339.641147.70506@localhost.redhat.com> Date: Tue, 15 Apr 2003 02:26:00 -0000 To: Daniel Jacobowitz Cc: David Carlton , Elena Zannoni , gdb-patches@sources.redhat.com, Jim Blandy Subject: Re: [rfa] annotate blocks with C++ namespace information In-Reply-To: <20030415020820.GB30534@nevyn.them.org> References: <20030311171133.GA3362@nevyn.them.org> <16027.2953.467195.516437@localhost.redhat.com> <20030415020820.GB30534@nevyn.them.org> X-SW-Source: 2003-04/txt/msg00305.txt.bz2 Daniel Jacobowitz writes: > On Mon, Apr 14, 2003 at 02:33:03PM -0700, David Carlton wrote: > > On Mon, 14 Apr 2003 15:27:05 -0400, Elena Zannoni said: > > > David Carlton writes: > > > > >> Just for reference, here's a slightly updated version of my namespace > > >> patch, following Daniel's suggestions. The only real change is that > > >> it adds a new command "maint cplus first_component" and a new file > > >> gdb.c++/maint.exp to test it. > > > > > Ok, I got around to this finally. It is basically ok, except for the > > > line between what is c++ and what is symbol table stuff. I think that > > > more stuff can be pushed into cp-support.c. See below... > > > > I have mixed feelings about your comments. My first reaction was the > > 'using_list' stuff more logically belongs in buildsym.c: it's about > > building a symtab, after all! So if the only reason to move it to > > cp-support is to shift the maintenance responsibilities (which is > > sensible enough, no need for you to look at changes that only affect > > C++ support), then I'd rather fix the maintenance process: make Daniel > > a symtab maintainer (he's certainly done enough work on symtabs), or > > at least allow him to approve C++-specific symtab changes. > > > > Having said that, I'm tentatively coming around to your point of view. > > After all, it's easy enough for me to say that everything related to > > building symtabs should be in buildsym.c, but if lots of different > > languages develop their own special needs for the symbol table, then > > buildsym.c will quickly degenerate into a mess of language-specific > > special cases. So maybe you're right. And, after all, cp-support.c > > is a lot smaller than buildsym.c, so it will be a while before it gets > > too bloated. > > > > Daniel, what do you think? > > I can see it either way - in symtab or in C++. Does it make sense to > have cp-namespace.c for this, do you think? I see it more as building language specific structures, and letting symtabs have a pointer to those. I think the cp-namespace.c idea is a good compromise. elena > > > -- > Daniel Jacobowitz > MontaVista Software Debian GNU/Linux Developer