From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9610 invoked by alias); 15 Apr 2003 02:24:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9603 invoked from network); 15 Apr 2003 02:24:23 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 15 Apr 2003 02:24:23 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h3F2OND04137 for ; Mon, 14 Apr 2003 22:24:23 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h3F2ONq01503; Mon, 14 Apr 2003 22:24:23 -0400 Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h3F2OL227547; Mon, 14 Apr 2003 22:24:22 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 58CCD2C444; Mon, 14 Apr 2003 22:28:45 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16027.28253.177535.902989@localhost.redhat.com> Date: Tue, 15 Apr 2003 02:24:00 -0000 To: Daniel Jacobowitz Cc: Elena Zannoni , Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: [RFA/TESTSUITE] build schedlock.c on 64-bit platforms In-Reply-To: <20030415020627.GA30534@nevyn.them.org> References: <16019.15635.929065.664152@localhost.redhat.com> <20030409131329.GA4525@nevyn.them.org> <16021.31692.763468.4182@localhost.redhat.com> <20030410141953.GA10379@nevyn.them.org> <3E96501F.95D6F7DC@redhat.com> <16027.26122.875009.304007@localhost.redhat.com> <20030415020627.GA30534@nevyn.them.org> X-SW-Source: 2003-04/txt/msg00304.txt.bz2 Daniel Jacobowitz writes: > On Mon, Apr 14, 2003 at 09:53:14PM -0400, Elena Zannoni wrote: > > Michael Snyder writes: > > > Daniel Jacobowitz wrote: > > > > > > > > On Thu, Apr 10, 2003 at 10:12:28AM -0400, Elena Zannoni wrote: > > > > > Daniel Jacobowitz writes: > > > > > > On Tue, Apr 08, 2003 at 05:20:19PM -0400, Elena Zannoni wrote: > > > > > > > > > > > > > > I was getting warnings when compiling the test on 64-bit because of the casts. > > > > > > > > > > > > > > > > > > > > > > > > Sigh, I was just sloppy writing this one. Does it work if you pass > > > > > > &args[i] instead of messing with my_number? That's a little more > > > > > > portable. > > > > > > > > > > > > > > > > Ok, how about this? But now get_current_thread in schedlock.exp > > > > > doesn't work, because the output has changed. I am not sure I > > > > > understand what it should be doing now. There is no way to get the > > > > > thread number from the backtraces. > > > > > > > > Oh, you're right - sorry for the wild goose chase. I think your > > > > previous patch with the cast to long is OK then. The test isn't > > > > terribly portable but it should be portable enough for our use. > > > > > > Why don't you just declare 'i' a long and be done with it? > > > > Daniel? > > Looks fine to me - portable enough for our purposes. ok, I committed it. > > > Index: schedlock.c > > =================================================================== > > RCS file: /cvs/uberbaum/gdb/testsuite/gdb.threads/schedlock.c,v > > retrieving revision 1.2 > > diff -u -p -r1.2 schedlock.c > > --- schedlock.c 23 Oct 2002 03:22:56 -0000 1.2 > > +++ schedlock.c 15 Apr 2003 01:47:34 -0000 > > @@ -13,12 +13,15 @@ int main() { > > int res; > > pthread_t threads[NUM]; > > void *thread_result; > > - int i; > > + long i; > > > > for (i = 0; i < NUM; i++) > > { > > args[i] = 1; > > - res = pthread_create(&threads[i], NULL, thread_function, (void *)i); > > + res = pthread_create(&threads[i], > > + NULL, > > + thread_function, > > + (void *) i); > > } > > > > /* schedlock.exp: last thread start. */ > > @@ -29,7 +32,7 @@ int main() { > > } > > > > void *thread_function(void *arg) { > > - int my_number = (int) arg; > > + int my_number = (long) arg; > > int *myp = &args[my_number]; > > > > /* Don't run forever. Run just short of it :) */ > > > > -- > Daniel Jacobowitz > MontaVista Software Debian GNU/Linux Developer