Re: [RFA/TESTSUITE] build schedlock.c on 64-bit platforms

Elena Zannoni
2003-04-15T01:48:59Z

Michael Snyder writes:
> Daniel Jacobowitz wrote:
> >
> > On Thu, Apr 10, 2003 at 10:12:28AM -0400, Elena Zannoni wrote:
> > > Daniel Jacobowitz writes:
> > > > On Tue, Apr 08, 2003 at 05:20:19PM -0400, Elena Zannoni wrote:
> > > > >
> > > > > I was getting warnings when compiling the test on 64-bit because of the casts.
> > > > >
> > >
> > > >
> > > > Sigh, I was just sloppy writing this one. Does it work if you pass
> > > > &args[i] instead of messing with my_number? That's a little more
> > > > portable.
> > > >
> > >
> > > Ok, how about this? But now get_current_thread in schedlock.exp
> > > doesn't work, because the output has changed. I am not sure I
> > > understand what it should be doing now. There is no way to get the
> > > thread number from the backtraces.
> >
> > Oh, you're right - sorry for the wild goose chase. I think your
> > previous patch with the cast to long is OK then. The test isn't
> > terribly portable but it should be portable enough for our use.
>
> Why don't you just declare 'i' a long and be done with it?

Daniel?

Index: schedlock.c
===================================================================
RCS file: /cvs/uberbaum/gdb/testsuite/gdb.threads/schedlock.c,v
retrieving revision 1.2
diff -u -p -r1.2 schedlock.c
--- schedlock.c 23 Oct 2002 03:22:56 -0000 1.2
+++ schedlock.c 15 Apr 2003 01:47:34 -0000
@@ -13,12 +13,15 @@ int main() {
int res;
pthread_t threads[NUM];
void *thread_result;
- int i;
+ long i;

for (i = 0; i < NUM; i++)
{
args[i] = 1;
- res = pthread_create(&threads[i], NULL, thread_function, (void *)i);
+ res = pthread_create(&threads[i],
+ NULL,
+ thread_function,
+ (void *) i);
}

/* schedlock.exp: last thread start. */
@@ -29,7 +32,7 @@ int main() {
}

void *thread_function(void *arg) {
- int my_number = (int) arg;
+ int my_number = (long) arg;
int *myp = &args[my_number];

/* Don't run forever. Run just short of it :) */