From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2861 invoked by alias); 7 Apr 2003 14:26:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2839 invoked from network); 7 Apr 2003 14:26:37 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 7 Apr 2003 14:26:37 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h37EQbe12537 for ; Mon, 7 Apr 2003 10:26:37 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h37EQbJ30319 for ; Mon, 7 Apr 2003 10:26:37 -0400 Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h37EQb322028 for ; Mon, 7 Apr 2003 10:26:37 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id C402E2C438; Mon, 7 Apr 2003 09:31:11 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16017.32156.807099.418676@localhost.redhat.com> Date: Mon, 07 Apr 2003 14:26:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] disassembly fixes In-Reply-To: <20030407133223.GA5011@nevyn.them.org> References: <16014.3984.767812.912971@localhost.redhat.com> <20030407133223.GA5011@nevyn.them.org> X-SW-Source: 2003-04/txt/msg00115.txt.bz2 Daniel Jacobowitz writes: > On Fri, Apr 04, 2003 at 06:04:48PM -0500, Elena Zannoni wrote: > > > > A few fixes for the new disassembler. I'll commit in a day or so. > > > > 2003-04-04 Elena Zannoni > > > > * disasm.c (dump_insns): Move variables inside loop, or they will > > be freed more than once, causing wild memory corruptions. > > (gdb_disassembly): Look for the substring "-thread", > > instead of "-threads" in the target name, to make sure to find > > the 'multi-thread' target. Also, make sure we do the right thing > > with the "core" target. > > While you're in there, any comments on: > http://sources.redhat.com/ml/gdb/2003-02/msg00153.html > ? > Hmm, yes, I think that logic is a bit screwed up (it came from gdbtk, and maybe there it was more appropriate), I have no objections if you want to revisit the heuristics. n hte meantime I would apply these changes anyway because disassembly with core files and threaded programs just doesn't work at all. elena > -- > Daniel Jacobowitz > MontaVista Software Debian GNU/Linux Developer