From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30937 invoked by alias); 7 Apr 2003 13:24:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30920 invoked from network); 7 Apr 2003 13:24:30 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 7 Apr 2003 13:24:30 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h37DOUe28375 for ; Mon, 7 Apr 2003 09:24:30 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h37DOTJ08656 for ; Mon, 7 Apr 2003 09:24:29 -0400 Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h37DOS315311 for ; Mon, 7 Apr 2003 09:24:28 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id ECDB02C439; Fri, 4 Apr 2003 17:22:11 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16014.1427.560745.693806@localhost.redhat.com> Date: Mon, 07 Apr 2003 13:24:00 -0000 To: Daniel Jacobowitz Cc: Joel Brobecker , gdb-patches@sources.redhat.com Subject: Re: [RFA/DWARF2] Fallback unknown language to C In-Reply-To: <20030312145855.GA2699@nevyn.them.org> References: <20030312014415.GE958@gnat.com> <20030312145855.GA2699@nevyn.them.org> X-SW-Source: 2003-04/txt/msg00112.txt.bz2 Daniel Jacobowitz writes: > On Tue, Mar 11, 2003 at 05:44:15PM -0800, Joel Brobecker wrote: > > I am hearing the first rumors of 5.4, I think it would be nice to have > > the following change in. It's a followup on a remark made in this > > message: > > > > http://sources.redhat.com/ml/gdb/2003-02/msg00533.html > > > > (GDB does not work very well when the language is unknown) > > > > 2003-03-11 J. Brobecker > > > > * dwarf2read.c (set_cu_language): Fall the language back to C > > if it is unsupported. > > > > Ok to commit? > > I agree with the remark, but not the method. Does anyone see an > advantage to the unk_* methods calling error() instead of silently > defaulting to the C versions? That seems more appropriate to me. > > I don't like too much the idea of making the unk_lang functions default silently to C. These functions, in my mind, also serve as a kind of error checking in case the language settings get screwed up during debugging. Maybe the solution is to provide a 'partial_language' set of functions which do the bare minimum. The thing I missed from the various postings was a real reason of why the behavior changed. I guess that for stabs we didn't detect any of these languages at all and we defaulted to C from set_initial_language(). elena > -- > Daniel Jacobowitz > MontaVista Software Debian GNU/Linux Developer