From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64942 invoked by alias); 5 Apr 2017 15:15:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64106 invoked by uid 89); 5 Apr 2017 15:15:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Apr 2017 15:15:57 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E7B65C04BD55; Wed, 5 Apr 2017 15:15:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E7B65C04BD55 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E7B65C04BD55 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4F55D83107; Wed, 5 Apr 2017 15:15:57 +0000 (UTC) Subject: Re: [PATCH 1/2] ptid_{lwp,tid}_p: Remove unnecessary checks To: Simon Marchi , gdb-patches@sourceware.org References: <20170404183235.10589-1-simon.marchi@ericsson.com> From: Pedro Alves Message-ID: <15fd0842-2c1d-3567-f707-3de79fa84e67@redhat.com> Date: Wed, 05 Apr 2017 15:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170404183235.10589-1-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00111.txt.bz2 On 04/04/2017 07:32 PM, Simon Marchi wrote: > The calls to ptid_equal in ptid_lwp_p and ptid_tid_p that compare the > argument to minus_one_ptid and null_ptid are not necessary. The calls > in question are: > > if (ptid_equal (minus_one_ptid, ptid) > || ptid_equal (null_ptid, ptid)) > return 0; > > minus_one_ptid is { .pid = -1, .lwp = 0, .tid = 0 } > null_ptid is { .pid = 0, .lwp = 0, .tid = 0 } > > If the ptid argument is either of them, the statements > > return (ptid_get_lwp (ptid) != 0); > > and > > return (ptid_get_tid (ptid) != 0); > > will yield the same result (0/false). > > gdb/ChangeLog: > > * common/ptid.c (ptid_lwp_p, ptid_tid_p): Remove comparison with > minus_one_ptid and null_ptid. Indeed. LGTM. Thanks, Pedro Alves