From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix regression in gdb.ada/mi_exc_cond.exp
Date: Thu, 12 Feb 2026 11:57:56 +0100 [thread overview]
Message-ID: <15f1cf02-d3f6-4b95-99a1-1b4e84dabc8b@suse.de> (raw)
In-Reply-To: <20260212024515.2546354-1-tom@tromey.com>
On 2/12/26 3:45 AM, Tom Tromey wrote:
> Tom de Vries reported a regression due to a recent change in
> gdb.ada/mi_exc_cond.exp. This patch should fix it.
>
Hi,
I've tested this, and LGTM.
Approved-By: Tom de Vries <tdevries@suse.de>
FWIW, I've submitted a follow-up patch cleaning up the test-case (
https://sourceware.org/pipermail/gdb-patches/2026-February/224928.html ).
Thanks,
- Tom
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33895
> ---
> gdb/testsuite/gdb.ada/mi_ex_cond.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.ada/mi_ex_cond.exp b/gdb/testsuite/gdb.ada/mi_ex_cond.exp
> index cfaf0577840..b901ebdd5c5 100644
> --- a/gdb/testsuite/gdb.ada/mi_ex_cond.exp
> +++ b/gdb/testsuite/gdb.ada/mi_ex_cond.exp
> @@ -38,7 +38,7 @@ if {[mi_clean_restart $::testfile]} {
> # catchpoint that uses both conditions and exception name.
>
> mi_gdb_test "-catch-exception -c \"the_test_index = 2\" -e constraint_error" \
> - "\\^done,bkptno=\"$decimal\",bkpt={.*disp=\"keep\",enabled=\"y\",what=\"`constraint_error' Ada exception\",cond=\"the_test_index = 2\",.*}" \
> + "\\^done,bkptno=\"$decimal\",bkpt={.*disp=\"keep\",enabled=\"y\",what=\"`constraint_error' Ada exception\",(.*,)?cond=\"the_test_index = 2\",.*}" \
> "catch C_E if the_test_index = 2"
>
> # It is important that we start the program's execution after having
prev parent reply other threads:[~2026-02-12 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 2:45 Tom Tromey
2026-02-12 10:57 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15f1cf02-d3f6-4b95-99a1-1b4e84dabc8b@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox