From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id f7O6ApGrbGQN1xEAWB0awg (envelope-from ) for ; Tue, 23 May 2023 08:03:29 -0400 Received: by simark.ca (Postfix, from userid 112) id EA7A61E11E; Tue, 23 May 2023 08:03:28 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=eUEnFBRD; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 205071E0D6 for ; Tue, 23 May 2023 08:03:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 604993858C78 for ; Tue, 23 May 2023 12:03:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 604993858C78 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1684843405; bh=Zvv3YR/Yr266rxMwa4RcaA/zHN0Y/dtkC9uAYAG5FEc=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=eUEnFBRDYhSn1kF6nv/WxaFkVRTpcvW5Uloyb97Hqbuu3IELE/t9ClZZUPGtiM63N eWY6ZnpHoZyUQO8b1PTw/Aqjq2FieErhgVpAb2G8BqNBkq+5UzARg9TLxSHwph+Q2m lH51+1WTq0giuFPskDM2qwz8Igdv6HBz6EG/S4EY= Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2055.outbound.protection.outlook.com [40.107.115.55]) by sourceware.org (Postfix) with ESMTPS id 1225E3858D35 for ; Tue, 23 May 2023 12:03:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1225E3858D35 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gDUiHjod40X6F1xr89aezbYgvgrkXm0GlADCwLXIUjn05rYCTAEuOD/CEn4ST2zPE6bwxzvno8vGy7DBgRt1upGM0/eawXkQrSMfr1aXeSRsl3d8pqCqD1Pzy45O1RgGgKEJ4gA5a2hF+OhlDgz/F32RmjdrNMVTE8jZkPMzvfIbovYqr+PYXaKyAnMTDxJO2okAta57sW2p+vOA7fY+3flAWaRAZATemjNi4w3oVLoEGvuPM/z507Z0+ATxiZMGWudm9fKMycpAIyHVRGDpmsnRza0oh6moCtSZYqfsafgNkzBx3TCTz0GMzDlPnmOgH6ibIvmWZR/qOh6NHbjvkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zvv3YR/Yr266rxMwa4RcaA/zHN0Y/dtkC9uAYAG5FEc=; b=KAU9viRcnCXqoztS8U9rJrdreK6hhSj4wcIDjCiKwaoz5vYoaTvq8Wqyu0B+1EULps4eBEpOUAd2kUKJX04NZk+VUOjG4RwoYjpRu7dztuslnUeh4++ttgAyiZ19YS12c+GahrWO0F1Oz/CsC4mXiciFbCYgXd7l6cWbRp3kDJ+RemutqxEcF5iH9BcfLZ3I03Hc/1xg+P2nfN1sgJeUYYHBrnULrD2lps23IjLKAhZcYIQkFW8S8oJ2sFdVjpiEQDCv/EWPZ0AWlRp3WD3Llp5fnd5hlaAHGw4uVaNxMqIWxzihUumsZzCQo350XJ4nYU5N1iUyx6Qc3YYsr0P1OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT3PR01MB5231.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:60::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.14; Tue, 23 May 2023 12:03:03 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::b7c2:2912:524e:8e80]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::b7c2:2912:524e:8e80%6]) with mapi id 15.20.6411.027; Tue, 23 May 2023 12:03:03 +0000 Message-ID: <15ed69df-3244-92e0-8d86-426a44d8b1e3@efficios.com> Date: Tue, 23 May 2023 08:03:01 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] gdbsupport: add support for references to checked_static_cast To: Kevin Buettner , Simon Marchi via Gdb-patches References: <20230518205737.403656-1-simon.marchi@efficios.com> <20230519143142.126781d9@f38-zws-nv> Content-Language: fr In-Reply-To: <20230519143142.126781d9@f38-zws-nv> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0124.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:5::27) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT3PR01MB5231:EE_ X-MS-Office365-Filtering-Correlation-Id: b74fc71b-27d9-4fd3-07dc-08db5b85a91e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: swq74NpQXwrF7WeMZIeJ5JaJ9OT66vfxdKMVQXzwlc+ugiKuwG/yeDDQEhZc7NijlGzzRcoRrVKsh6CENGdkWOwJ4HHNW3a5vdF2CBQvf2Tyv23VvVb7fclJLLQ6MMoaWGbKzmy5F1yLcJfbCI8MXRgp3i3Q9S+03CVra9hVY2uzUgY/10bghYNsiRFEdhaUs+hFEaWk4zn+53CyaTyVRgUY1J/d8ekeyTzUqpWJwa0wtCNDYgBIbgMAFN+S52oz4K+eA4ijFCGFKNS31PPcQRje/1MedKyuxi7A/bBzuPnRAlKucrcgM105QFT9hoX3l5/ILBnZA8V9KzQS+/VfHkp8Wfy0rSUDVbUTv54arPustcTRONDzh0bUnd4aoB/gBh6fw4mUwBaizTKDpjATTVe8x2+z2Vv+Y2HIMqEyy/OYCjz1utIFD/c1faEZ19M1y46Fev3l3Qd8cCn5TR4UcQN8f40nBiavkMZMShIKHiijTPF/icjiZFGseb3nKOyW9WIAZRS9i0QhnHEHqurWMHB3mjqAobEBDeDl7/PbdYt083QgqmBBhfM/fPWcEfYz01ke74QxMSqKguo7oH4chLz8hAo/RitCskIekMZjyrltuY0w2nAMo3wgCqMltTDjb2CIa1xuMNmwNU6vQQ3zDA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230028)(136003)(39830400003)(376002)(366004)(346002)(396003)(451199021)(8676002)(8936002)(44832011)(5660300002)(83380400001)(53546011)(6512007)(186003)(6506007)(26005)(31696002)(2616005)(38100700002)(41300700001)(6486002)(478600001)(36756003)(66556008)(66476007)(66946007)(316002)(110136005)(31686004)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzVOQjFLYmlRMTIrWStRc3FjMlhWUW5TaUhQYTByalZKMVc0N1BIOStFeVVE?= =?utf-8?B?MXhSMG0wYUQxOWVYZFVHSStJZ2J2aWRFNVNTTW1vblN4ZU81KzF3SjFnMzM1?= =?utf-8?B?OGIrRGFqUTc5OHVtR25mT1JBcFFDMnlmR1FzVXlYK2toNkl1d1AzWGtxZ1o3?= =?utf-8?B?TlY1eWxuK2ZQcXJOU2pSOWlIdXBTMW1zamV3VE9LdHdZZ3VRUmx6S1E1cWlD?= =?utf-8?B?c0NnNUpWdXZUMkVhRHQ5R25hWUhOaVNZUXpvN2RQRWo2Q3kvRk9NblRnN3Bz?= =?utf-8?B?NWZ0S282SWh1cnNoSWgzamdtRFpUeDRVM3d6dmpDdGpwSlBYbGRsUy95R0J6?= =?utf-8?B?SDRBcllnYzBuYlZOTlB2M2szR3VCNEZQTHkzOG5Sd2UxeVRibStGRllkQVFL?= =?utf-8?B?TDRBYzMwU1huWVV0VWN4REFQLzFiQ01hTk0xbGh1SzJsZS9CMndrdkRGcHkx?= =?utf-8?B?bGoxWXhCUW9ERWhWOHhCREZ4dmhEMUIrQW1kazJFTFJsZWJjbUQxdURoMzlW?= =?utf-8?B?SHI1b1gxUnlSWk5kMzVZL2FCamt1aXdHbm1VeGJRcStnN2VhT3RIOWR5KzRY?= =?utf-8?B?WUFzSHl0cXU2bEVUNlgrQlNLUlNNNVJxbmwvTitRQnpQRzl2anVIQWNhWlZW?= =?utf-8?B?YTRwZHhOa1NzcWppN0haeG9Fa1IwejJ5am95T1VJRExYdmFkTGFwN25TenVO?= =?utf-8?B?VFcyRDlpbUlveGRQNEhydkNTSmlMOWh5M3ZkRFQzQkxFZTBDVWZSY0xjallN?= =?utf-8?B?bE1tNGswMGdtTkhUZGQzaDZySDM4SEtPSk5XY0pTckFPeUdtQUFZL1VrRTgz?= =?utf-8?B?MzRzQ1d6aktZRTAwRDB0bmRyeitRd0owdWlWdHBkNWpCd1RMR3dCZTFQM2NT?= =?utf-8?B?MGdPL0RJUVF4ak44WitJWGRFUzVwV0FSZUlOWjI0VWhjdXNXdzhoZTBSYU52?= =?utf-8?B?L2VUc29KU3VjSWtCek9yTi80N0lnaWFHbEZJc2ZhTCt2N1BBVlNlWWY1THVS?= =?utf-8?B?U2FZbUZ5ZmxjbmNPYzdqa2dROHRzdEJyUklNMklQU0tiK09iclc1b1FMUkN1?= =?utf-8?B?T0c3dmJ2K1l0Y3lKbXFQclFKaWdXY0hISXZEZ2xaYlMrS09DMW8zYmFTUnJC?= =?utf-8?B?R01wcGU0NDhBb0hYK3JtUmRnb0VScjlvSXFYZkt0VDBNUVVrZjhVTDcrR2dJ?= =?utf-8?B?dkp5WTM0WnZzUy9MMVRRckFkOTNYQ20xSzd3K1oyc3plNFpEM3dTYVpTaUZ5?= =?utf-8?B?L0dZdE9vNGd4TCt1amc1TStBUHJYc0k1QkREaFgyTzJGNlBNU2d0SlltWnY5?= =?utf-8?B?KzNYYk9PWnZaTWVjazdkbStKNDZVTW9zL01xMGF6V0lyK1dUWjlBNktXOVQ2?= =?utf-8?B?a25jdm9uZ3J0MkN4UDdHLzVSZGV6WjVjREhrdXNHMUd6THFsQmJwTmM3VmhP?= =?utf-8?B?Tldleng0QmxrK2lhVEJvM0l0dGZrK01kazQwMWZWYVdLZGVJRkJQa0o4U0N3?= =?utf-8?B?Ti9MaXAveUxmQVE0OG9CRjkyYU5HcFlrbi85bFNIMDRNRGZvTlJzSEpnbTB3?= =?utf-8?B?cXJZVXIvVldlamx4VDZUNjVoUXlOR0hUWERORTRJV1J3cVdvTVVVbTJLY0NG?= =?utf-8?B?NXlTOXl0cnV3b0cyMjV3WjBpa1lhRUE5M3ZtTzExc1Q0UDJWc2Y5UHJHTUR6?= =?utf-8?B?QzB4akxySjIybkIzcVlGUjl2T2JONHJsbTE3RWlFelc3c2dWdWpIMHNZZG8r?= =?utf-8?B?WW90T0tXb3UzMjBDNHY4am10Y1B0cUJMRHg4YXdDYnM3RkliazlCTkJJLzRa?= =?utf-8?B?WFd1Mlo5eVNKNFF6aTlZY0dveTgwOU0yNXRBZG0vMXhSbzU5bm9ONFFuUncy?= =?utf-8?B?SW8rQU16SkxOZU5mREVlbU9SOUhOWmhuMFFhbFYxVXcwZXNmV0pTaDZITmJB?= =?utf-8?B?ODg0V3p5SExrRndsanRtTkdOTFBCNXBPZGdoc2Z5OEwrRkcya0dxdzgwV0Fr?= =?utf-8?B?OWRYV1ZIaVMzTUNiTzhsUURPSnRNL0VESGpQV0U2WXBac0Y5R1NoUEkrd203?= =?utf-8?B?eHA1eUxBQVVlVkswNm15WUd4Rzl4OG9mVHRLN1MxZlBiYVdoMjFQZVRQck1H?= =?utf-8?Q?qYQLPcwpsOKU34jNSe4V2+/zo?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: b74fc71b-27d9-4fd3-07dc-08db5b85a91e X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 12:03:03.0937 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rcZEngO7lKmXlYfIH1X6NsqJ15tugRwpuTYP8q+xR59Q5IEXcJ1EFxW3JnljSC+DrKBSgk27qn5N8TNHMOpQng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB5231 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 5/19/23 17:31, Kevin Buettner wrote: > On Thu, 18 May 2023 16:57:37 -0400 > Simon Marchi via Gdb-patches wrote: > >> Add a checked_static_cast overload that works with references. A bad >> dynamic cast with references throws std::bad_cast, it would be possible >> to implement the new overload based on that, but it seemed simpler to >> just piggy back off the existing function. >> >> I found some potential uses of this new overload in amd-dbgapi-target.c, >> update them to illustrate the use of the new overload. To build >> amd-dbgapi-target.c, on needs the amd-dbgapi library, which I don't >> expect many people to have. But I have it, and it builds fine here. I >> did test the new overload by making a purposely bad cast and it did >> catch it. > > I'm not especially knowledgeable in this area, but it LGTM. > > Acked-by: Kevin Buettner Thanks, I'll add your Acked-By. I'll wait to see if Andrew has anything to say about it, since he wrote the original feature. Simon