Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Jan Vrany <jan.vrany@fit.cvut.cz>,
	gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC] mi: print frame architecture when printing frames on an MI channel
Date: Tue, 21 Aug 2018 15:42:00 -0000	[thread overview]
Message-ID: <15de754b-78b0-8eaa-6c26-6f14077fa0a9@redhat.com> (raw)
In-Reply-To: <20180820204250.16301-1-jan.vrany@fit.cvut.cz>

On 08/20/2018 09:42 PM, Jan Vrany wrote:

> diff --git a/gdb/NEWS b/gdb/NEWS
> index 7f9466567f..43663fd315 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -41,6 +41,11 @@ thread apply [all | COUNT | -COUNT] [FLAG]... COMMAND
>    FLAG arguments allow to control what output to produce and how to handle
>    errors raised when applying COMMAND to a thread.
>  
> +* MI changes
> +
> +  ** Command responses and notifications that include a frame now include
> +     the frame's architecture in a new "arch" attribute.
> +

Note that there's already an "MI changes" section, added for your
"-data-disassemble -a" patch..  The new entry should go there.

Otherwise this LGTM.

Eli, can you review the documentation bits?

Thanks,
Pedro Alves


  reply	other threads:[~2018-08-21 15:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-10  5:57 [RFC] mi: Print " Jan Vrany
2018-08-10 10:30 ` Pedro Alves
2018-08-13 10:53   ` [RFC] mi: print " Jan Vrany
2018-08-16 19:01     ` Pedro Alves
2018-08-20 10:24       ` Jan Vrany
2018-08-20 11:16         ` Pedro Alves
2018-08-20 20:43           ` Jan Vrany
2018-08-21 15:42             ` Pedro Alves [this message]
2018-08-21 16:16               ` Eli Zaretskii
2018-08-22  9:43               ` Jan Vrany
2018-08-22 11:39                 ` Pedro Alves
2018-08-24 20:22                   ` Regression on gdb.arch/amd64-invalid-stack-*.exp (was: Re: [RFC] mi: print frame architecture when printing frames on an MI channel) Sergio Durigan Junior
2018-08-27 13:37                     ` Jan Vrany
2018-08-21 16:16             ` [RFC] mi: print frame architecture when printing frames on an MI channel Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15de754b-78b0-8eaa-6c26-6f14077fa0a9@redhat.com \
    --to=palves@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.vrany@fit.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox