From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KF2VK7HpQmi7OwMAWB0awg (envelope-from ) for ; Fri, 06 Jun 2025 09:14:25 -0400 Received: by simark.ca (Postfix, from userid 112) id AFE271E11C; Fri, 6 Jun 2025 09:14:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 243C91E089 for ; Fri, 6 Jun 2025 09:14:25 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A2E66385697E for ; Fri, 6 Jun 2025 13:14:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A2E66385697E Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by sourceware.org (Postfix) with ESMTPS id 54D0C3858CDA for ; Fri, 6 Jun 2025 13:11:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 54D0C3858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 54D0C3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749215481; cv=none; b=Z++FMNbVk/JGa7hqBD7v5do6UaV95H4I0Qmf0DCWPEjLTmBl7Vmx3MD+8axUdlfPTYZIMs7peCDzT/oj+kc0+c1qfw2rYyFlOM7PZNwlWREQb+9d9t+TL0g8EuapomaqY1aT85zzSMQo2S0QAw3LA5xqimgaozBVhzAegFc/l1Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749215481; c=relaxed/simple; bh=MncWbUWEZ/GfKOFQrLRyydMYxHMpjhcCR3JkS8AEX5Y=; h=Message-ID:Date:MIME-Version:Subject:From:To; b=JP1pobs1fZYCpZPyRFFmhJXwYknRexSAy2059W8gse3NHgyhsBgUFTCOy2T+3N2yOJmwQWh0yVhDf9rViFyZjlAhKTqkRxaMlDpFOKB1gMqFXMjaCBfM/inEaP1eHTrHhx9U8IP/wGRx8JbOVjKwuiiJk9hT8DkGETGIaijGu9M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 54D0C3858CDA Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-ad89c32a7b5so336020366b.2 for ; Fri, 06 Jun 2025 06:11:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749215480; x=1749820280; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ICPaULfmEEM6Ac/T+9MeuFLb2zE5Uat//F9PlM8Ilq8=; b=GofVuaJNAUrLrJMszNYPxU2C8iyy8UslJCR73uvvaEtwJnrRxsaDrjLRwpZ6bRUh+r z9gPtb34UkZCQaHIlKHvfKzmaqH7dNHARhGO2OrXhmIhWqU8LVF37HsNPkABMxjOO5mQ s/CEuCEe5rI2htoV7fa42UAFOBqTxbiarxkmSJFw6Q0Qyq/HW9Nm2pldjgeeSRJ+a7yd cHVl3+yBaVjoRU4tfgeM6f5XMzuqVxXf3QLyTzLHv7kUDDvGAO3dzSUzyHs55ZsYu5gY yvvP+uDLZCA/vVj+3UCV2TSJuLqeQsQY05RZFoNcIHbUszWYCOxdIs93Gdiwqt6nfcpG 8QsA== X-Forwarded-Encrypted: i=1; AJvYcCWmIKJp60gkihzmODws1DBfIbtDK2kaviNFBG14JA92HmnNrA5bQ8sERaUJDofEx5VRmP+w9ImQgFhqoA==@sourceware.org X-Gm-Message-State: AOJu0YwyG2P8jpaZrlcnnmZEajhKiGU9bLc/ESl46ImXeZ4tqmQfkGRL OfztGAK/Z63IBP8UAB+TfbH70aMUYjulTe5onageedzbPAH7TQWnDy44 X-Gm-Gg: ASbGncvg0QNfvNS/EnbTi1wMry4zHq+Z3Oo3hmNZ5SzxH2neMZAXkxmm7k5J46GtpEw yo6H5PUe55EkB/0NOhowNq0IiOQAq0qCfFjm8VQMFKgGQhpC2RuYP0al5GxJOVbTvPlWXovxOkL UQHje2wkLcJU1oCwPsHPj5BCLgIayKYyZpgh+mPxdMVmFJVyi8YiTNO8xoE5EI9KDvxcKdeAvpC cGO17M7W/Rtu5gD6qmVnZaiio+v5MzEWHAllm4P8G/731RXZ8hkGnmwy/Poe7TK3xnjB2m5Strr Ll6wWcT9qb/8fFlqEvXM3Z5fuh6RTU/jSNaqYqX/i9wvu8cygtvdTmgeYEgtDGem8OUAZ+eiQFA jyxzljFuIt75UKmNE X-Google-Smtp-Source: AGHT+IHFQI7fqSSd1XBZvs7GhuwcJ5XvoF+lExiAijuzu6cIR4HMYqVdaLWiOufu9TC9mdSshwzVHQ== X-Received: by 2002:a17:906:7315:b0:adb:4917:3c10 with SMTP id a640c23a62f3a-ade1aaff6ecmr275970766b.60.1749215479748; Fri, 06 Jun 2025 06:11:19 -0700 (PDT) Received: from ?IPV6:2001:8a0:facf:2b00:77f6:647:8d2f:f905? ([2001:8a0:facf:2b00:77f6:647:8d2f:f905]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ade3612ed50sm1630966b.6.2025.06.06.06.11.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 06:11:19 -0700 (PDT) Message-ID: <15d44b6f-bf37-47a3-a38e-767daa8270ce@palves.net> Date: Fri, 6 Jun 2025 14:11:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tdep] Don't call WaitForSingleObject with INFINITE arg From: Pedro Alves To: Tom de Vries , gdb-patches@sourceware.org References: <20250605150330.26246-1-tdevries@suse.de> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-06-05 17:15, Pedro Alves wrote: >> However, testsuite progress ground to a halt at >> gdb.base/branch-to-self.exp. [ AFAICT, similar problems reported >> here [1]. ] > The testsuite fails to kill gdb all the time for me, it may well be > the same. I'll give it a try after you've merged it. > I tested this now, and, unfortunately, it makes no difference for me. With upstream from before your patch, and I do see a gdb.base/branch-to-self.exp hang. However, after your patch, I still see the same hang. If I attach another GDB to the hung GDB, I see several other GDB threads stopped in WaitForMultipleObjects with an INFINITE argument, in Cygwin code, so I'm puzzled on how changing that particular call made a difference for you. :-/ Wonder if it's just a happy coincidence of affecting the scheduling. I've long suspected that this is actually some deadlock bug in Cygwin somewhere around closing stdin/stdout, and I still suspect so. But I can't discard it being a GDB bug. I didn't use to have this issue maybe a year ago, then I stopped working on Windows for a few months, and when I got back at it, I started seeing the issue. It's like some Cygwin update, or Windows update caused the issue. The hang is like other hangs I've observed before, it's around closing GDB to restart it for more tests, and the patch at: https://sourceware.org/pipermail/gdb-patches/2025-May/217949.html still helps with it for me. With that one on top of yours, and with gdb.base/branch-to-self.exp, I get: WARNING: closing gdb failed with: child process exited abnormally (the same as what I get without your patch) and the testcase moves on and finishes properly (though a couple tests fail with timeout, as they do for you.) If I look at the task manager while doing a full testsuite run, I see a bunch of leftover gdb.exe processes and their children still running, because dejagnu fails to properly close gdb.exe. Pedro Alves