From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] gdb: improve disassembler styling when Pygments raises an exception
Date: Fri, 7 Oct 2022 22:25:04 -0400 [thread overview]
Message-ID: <15cf0c9f-81ae-9bc8-79ba-e5b4eb1f0412@simark.ca> (raw)
In-Reply-To: <e49e04c2dd1f0723dccb2774664f41d7fa4f3df9.1661868744.git.aburgess@redhat.com>
> +# Check that, if the user is using Python Pygments for disassembler
> +# styling, then the styling correctly switches off when an error is
> +# detected in the Python code.
> +proc test_disassembler_error_handling { } {
> +
> + # This test requires the Python Pygments module to be installed
> + # and used by GDB.
> + if { !$::python_disassembly_styling } {
> + return
> + }
> +
> + save_vars { env(TERM) } {
> + # We need an ANSI-capable terminal to get the output.
> + setenv TERM ansi
> +
> + # Restart GDB with the correct TERM variable setting, this
> + # means that GDB will enable styling.
> + clean_restart_and_disable "restart 4" $::binfile
> +
> + # Disable use of libopcodes for styling. As this function is
> + # only called when Python Pygments module is available, we
> + # should now be using that module to style the disassembler
> + # output.
> + gdb_test_no_output "maint set libopcodes-styling enabled off"
> +
> + # Disassemble a single instruction and ensure that the output
> + # has styling markers in it.
> + set insn_before [get_single_disassembled_insn]
> + gdb_assert { [regexp "\033" $insn_before] } \
> + "have style markers when Pygments is working fine"
> +
> + # Now replace the standard function that colorizes the
> + # disassembler output, with a new function that always returns
> + # None, this should cause GDB to stop using the Pygments
> + # module for disassembler styling.
> + gdb_py_test_silent_cmd \
> + [multi_line_input \
> + "python" \
> + "def replacement_colorize_disasm(content,gdbarch):" \
> + " return None" \
> + "gdb.styling.colorize_disasm = replacement_colorize_disasm" \
> + "\004"] \
Any reason you are using \004 here, instead of end? I don't quite
understand why, but it seems to cause some random failures. Running the
test under `taskset -c 2` makes it fail most of the time. Running it
with check-read1 makes it fail consistently:
FAIL: gdb.base/style.exp: capture_command_output for x/1i *main
When changing \004 for end, it passes. I don't have an explanation why
though.
Simon
next prev parent reply other threads:[~2022-10-08 2:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 14:16 [PATCH 0/3] Improvements for Pygments based disassembly styling Andrew Burgess via Gdb-patches
2022-08-30 14:16 ` [PATCH 1/3] gdb/testsuite: extend styling test for libopcodes styling Andrew Burgess via Gdb-patches
2022-08-30 14:16 ` [PATCH 2/3] gdb: improve disassembler styling when Pygments raises an exception Andrew Burgess via Gdb-patches
2022-10-08 2:25 ` Simon Marchi via Gdb-patches [this message]
2022-10-08 16:00 ` Andrew Burgess via Gdb-patches
2022-10-08 16:01 ` Simon Marchi via Gdb-patches
2022-10-10 9:32 ` Andrew Burgess via Gdb-patches
2022-10-10 10:31 ` Tom de Vries via Gdb-patches
2022-10-10 11:16 ` Andrew Burgess via Gdb-patches
2022-10-10 13:22 ` Tom de Vries via Gdb-patches
2022-10-10 14:04 ` Andrew Burgess via Gdb-patches
2022-10-10 11:03 ` Andrew Burgess via Gdb-patches
2022-08-30 14:16 ` [PATCH 3/3] gdb/disasm: better intel flavour disassembly styling with Pygments Andrew Burgess via Gdb-patches
2022-10-02 16:38 ` [PATCH 0/3] Improvements for Pygments based disassembly styling Andrew Burgess via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15cf0c9f-81ae-9bc8-79ba-e5b4eb1f0412@simark.ca \
--to=gdb-patches@sourceware.org \
--cc=aburgess@redhat.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox