Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v4 3/3] Fix failure to detach if process exits while detaching on Linux
Date: Fri, 24 Jun 2016 19:28:00 -0000	[thread overview]
Message-ID: <15ac6760-0c08-09a6-38a3-6a124ee2731f@redhat.com> (raw)
In-Reply-To: <86k2hnsvk0.fsf@gmail.com>

On 06/17/2016 04:07 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
> 
>> +# If testing single-process, simply detach from the process.
>> +#
>> +# If testing multi-process, first detach from the child, then detach
>> +# from the parent and confirm that the parent exits, thus unsuring
> 
> s/unsuring/ensuring/ ?

Indeed.

>> +	} else {
>> +	    perror "unhandled command: $mode: $cmd"
> 
> no variable "mode".

Whoops, there used to be one.  Fixed now (the two instances):

-           perror "unhandled command: $mode: $cmd"
+           perror "unhandled command: $cmd"

Thanks,
Pedro Alves


  reply	other threads:[~2016-06-24 19:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 23:33 [PATCH v4 0/3] " Pedro Alves
2016-06-16 23:32 ` [PATCH v4 1/3] Factor out "Detaching from program" message printing Pedro Alves
2016-06-17 11:31   ` Yao Qi
2016-06-16 23:33 ` [PATCH v4 3/3] Fix failure to detach if process exits while detaching on Linux Pedro Alves
2016-06-17 13:03   ` Antoine Tremblay
2016-06-24 19:30     ` Pedro Alves
2016-06-17 15:07   ` Yao Qi
2016-06-24 19:28     ` Pedro Alves [this message]
2016-06-16 23:33 ` [PATCH v4 2/3] Forget watchpoint locations when inferior exits or is killed/detached Pedro Alves
2016-06-17 11:56   ` Yao Qi
2016-06-24 19:10     ` Pedro Alves
2016-07-01 10:49       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15ac6760-0c08-09a6-38a3-6a124ee2731f@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox