From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1Yj5DInPsV8RUQAAWB0awg (envelope-from ) for ; Sun, 15 Nov 2020 20:02:01 -0500 Received: by simark.ca (Postfix, from userid 112) id 2753B1F08B; Sun, 15 Nov 2020 20:02:01 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CD4AD1E58F for ; Sun, 15 Nov 2020 20:02:00 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 400083857C46; Mon, 16 Nov 2020 01:02:00 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 40CB83857C46 for ; Mon, 16 Nov 2020 01:01:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 40CB83857C46 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CE5B71E58F; Sun, 15 Nov 2020 20:01:57 -0500 (EST) Subject: Re: RFA: Various enhancements to the fixed-point support implementation To: Joel Brobecker , gdb-patches@sourceware.org References: <1604817017-25807-1-git-send-email-brobecker@adacore.com> <1605430184-81335-1-git-send-email-brobecker@adacore.com> From: Simon Marchi Message-ID: <15abf53a-d3e7-7cf4-e3dd-9079a4dc71cc@simark.ca> Date: Sun, 15 Nov 2020 20:01:57 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1605430184-81335-1-git-send-email-brobecker@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-11-15 3:49 a.m., Joel Brobecker wrote: > Hello, > > The following patch series implements the suggestions Simon made > in reviewing the first patch series, which I felt deserved to be > their own patch. I think it allows us to review those changes > independently of the first implementation (which Simon said was > find to push). > > - [RFA 1/6] change gmp_string_asprintf to return an std::string > - [RFA 2/6] gmp-utils: Convert the read/write methods to using > - [RFA 3/6] gdbtypes.h: Get rid of the TYPE_FIXED_POINT_INFO macro > - [RFA 4/6] Make fixed_point_type_base_type a method of struct type > - [RFA 5/6] Make function fixed_point_scaling_factor a method of struct > - [RFA 6/6] valarith.c: Replace INIT_VAL_WITH_FIXED_POINT_VAL macro by > > The patches were tested on x86_64-linux. > > Thank you! > -- > Joel > Apart from my comments on patches 1 and 2, it all LGTM, thanks! Simon