Re: [RFA]: ObjC Testsuite

[Elena Zannoni <ezannoni@redhat.com>]

Adam Fedor writes:
 > 2003-02-19  Adam Fedor  <fedor@gnu.org>
 > 
 > 	* Makefile.in (ALL_SUBDIRS): Add gdb.objc
 > 	* configure.in (AC_OUTPUT): Add gdb.objc/Makefile.
 > 	* gdb.objc, gdb.objc/Makefile.in, gdb.objc/myclass.exp,
 > 	gdb.objc/myclass.m: New files.
 > 
 > Index: testsuite/Makefile.in
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/testsuite/Makefile.in,v
 > retrieving revision 1.5
 > diff -u -p -r1.5 Makefile.in
 > --- testsuite/Makefile.in	9 Jan 2003 18:50:21 -0000	1.5
 > +++ testsuite/Makefile.in	14 Feb 2003 04:24:47 -0000
 > @@ -36,7 +36,7 @@ EXEEXT = @EXEEXT@
 >  SUBDIRS = @subdirs@
 >  RPATH_ENVVAR = @RPATH_ENVVAR@
 >  ALL_SUBDIRS = gdb.arch gdb.asm gdb.base gdb.c++ gdb.disasm gdb.java gdb.mi \
 > -	gdb.threads gdb.trace $(SUBDIRS)
 > +	gdb.objc gdb.threads gdb.trace $(SUBDIRS)
 >  
 >  EXPECT = `if [ -f $${rootme}/../../expect/expect ] ; then \
 >            echo $${rootme}/../../expect/expect ; \
 > Index: testsuite/configure.in
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/testsuite/configure.in,v
 > retrieving revision 1.8
 > diff -u -p -r1.8 configure.in
 > --- testsuite/configure.in	4 Jan 2003 15:37:36 -0000	1.8
 > +++ testsuite/configure.in	14 Feb 2003 04:24:48 -0000
 > @@ -115,4 +115,4 @@ AC_EXEEXT
 >  AC_CONFIG_SUBDIRS($configdirs)
 >  AC_OUTPUT([Makefile gdb.arch/Makefile gdb.asm/Makefile gdb.base/Makefile \
 >    gdb.c++/Makefile gdb.disasm/Makefile gdb.java/Makefile gdb.mi/Makefile \
 > -  gdb.threads/Makefile gdb.trace/Makefile])
 > +  gdb.objc/Makefile gdb.threads/Makefile gdb.trace/Makefile])


I looked at the test files. I wouldn't call the tests
'myclass.*'. Maybe something more descriptive like objc-class.exp
objc-class.m ?

You may want to look at the gdb_compile_pthreads function in gdb.exp.

Also, when you set breakpoints, the patterns to match are very
generic, how can you be sure the breakpoints have been set in the
correct spot?

I'll let MichaelC comment more.


elena