From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cnpHH63Z7V9mJwAAWB0awg (envelope-from ) for ; Thu, 31 Dec 2020 09:01:17 -0500 Received: by simark.ca (Postfix, from userid 112) id 7228D1F0AA; Thu, 31 Dec 2020 09:01:17 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 505601E552 for ; Thu, 31 Dec 2020 09:01:16 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9F0BA385800A; Thu, 31 Dec 2020 14:01:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9F0BA385800A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1609423275; bh=bux6kBvOeoOryQfXQW1rSumi6PUdMpYg4rYRUyWkaYc=; h=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=lI3FurYGF4Ua7TX3cj1368ccW9b2bb1v6k58AOInuOjPU5C0Z0WsMY1TVoKw5/mzB 0L+/y30C7SFI94NPUGJQ3qggM/xmenhPAsnYfMx5YH4WU2vpNI3VVigif1aJ4FR5Ct Kptluca2/UsmHdph9UJVoLIGDmkm6g6nfLK4wIYU= Received: from sonic301-21.consmr.mail.ir2.yahoo.com (sonic301-21.consmr.mail.ir2.yahoo.com [77.238.176.98]) by sourceware.org (Postfix) with ESMTPS id 82363385800A for ; Thu, 31 Dec 2020 14:01:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 82363385800A X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1609423269; bh=NFtY0W7S0AfdtXLFgNDgiJuKLQa+2TbCBs/aIOYdIQv=; h=Date:From:To:Subject:From:Subject; b=OiXpq8TtZVpy4fc8nIYsYP3xfVdBZbSZawWj0HZ6yxp/axqKQv4zX5O9VowaXivFVDlPrBfgXb8HesGqKy4wYnj1S6R+L1LIVBmOWRm/isFfuMzucdVbwYmOvdTIliMINSYzSO6Qp0uZVU7EFEMqiH+IIubLadO7zVm/cWGIWIto4thhFg4wrtSJZYzVwlKPR9TunyrAntNT34CLCzEst/wwhbEWq6N1h4ny7jTclcIsIA3zkFEyQEUpUAfnOBQ/6c4wV+iMmw2iL0kJlcYo3Rdq7HFBq2zmh+uUWal9w9P9cv6WYBov7cN7CR/PRYbYZECA2P6p8KbbBDCbteCIng== X-YMail-OSG: el2SPxUVM1nZLuGWxmgmtmhru2zBxEwHGK5OIiDR_uUV4EvADaYqCrQtcdWbQa3 wbe_OAEZmhQvrkw562dOybLB8jCMPSHwP3q9G.QZzxPYs6YC4bA3D21wAdtlzvw2i2gvH0G_wj5T V11rSHUHwIk.zfr0dVt1IHHYN7CbygHpiaB9RrytkScawKpBprOf66HyWf90heHbfyhs6Nus1KBb PH2cOWfnKraVFVAxGxvcSFpToXA7J3X7VaX4JEn_rVVOIsg2hINrNVqOTkhjSJwn0I.DWIrV0cRa HIK6vA8xirkiUQaa08KvbWSvN7lMW5R4z9SKlb8R56b2ZOki6kl8UeWYPf2t10F7Vjq9oJFXDqjL LLpwQl.uF25FD.obRWQQl8d0guoseZyd3D5sDCZJ_cVTshmWaZtKnfV1_fJj2hxEgG1oHNpcKdYH iFV2XrnZlGX7l1ZShYTqzA.0A6XnLvijS8QMlVnu0xWZ4CjdCp95IZ0uTkFmgyVgUCfRwJJCbuIM Hd3kBbtBdq4l.DeU1lGaW49lBkM7zu0pPH9HIsLwE6Nzu7Nxop0rscIMmGFlFfW703ZsR0bkZFq6 XXI5AWfAQcBUBNbFsybNSVehS8BHaKIICCm7BwLOeG453mBrLH6iRnfQNhXlCuQjZBVYGXdLgMP5 wkIx4pwR6F7VVF9tIe1uag7lHxHm9nbLCFf.bwcpcU_q2L6C1lGYKkf92VXcXDlcx5QyRxetesit OH17CkcWUFFjfkTDdmkWeq9AJnsgoh6_JgI4TWVg3OLjtUtXaog_64IHhrzE51SHluEhWL.XAQ5J 8SR8fGsyt4kxErz.2r1jHGOwqc_lpTl5Emvb6aGm7ZOdIPhxyotOzYS5..A_aQVHRpATGWwyoIUk VykDWFRWWlDe1302gyUC36PkT.YNkUdO.Zw735V6F4Ap78UOcvgZNQQKwTAixo18cbb6tqwspQ6L .3ePNJbq99KST.RQR3owmKtdDBhS4onLR_GEEutoDSifgUht8BmgTh_q5adqlgSwNm2wd.9AESYW fhx6UO2wHhOm3Lddd6NO.C4YQwXr0fXb6VjfSvPy5Pifa0BSFSMt6YdLnaSwKAuB5O3rKhSVxdrS u2ZtVZ.WsB2.fygHQsMOnUcGaP4MEggeU23ffQXDstaaTMkLJgW3t1_wGtUv.eVnft7N41UC6Z4e QHndPPKdMO30yMPC80JR1HWKypWpjY43xyhohuKeImlGc4H6Umi8Uc5pwSb9VSrxQXm6gk7pIqCQ DRF1h2H35mGC8_XWKjL9wo0Ue6VlzxIjBIOmnlWeRlZMF0C5PsSB89rs39npLe.wGs5wOxvY6HBy 2YFNQqKaVnAtyQfFw7DUDNSIOhwLLYSnIacYMJl1MiU7L9I5IDZgDdtzXUtg1iCR39.hK4ocj3FC Hu9o5WBeeCuCdXcSzD5RVXXDZagHuolOyaflVkHyMIN9v0un6fpfbHszf39q0Va0JeUkLcjt99XE 2CKWLXDne8icukJLEvSR855Ye5uMsocsqnMXO115.2LCWm.20LlNRhAAoqy94wqndIDR_gmfeTAB Hi8s_Iiic9aEPgTm6U_tJWpR43s2Vlh_NggrWutrULRuw_kl.f8lcif820FjzpIVMiDi1p1G6uv7 4V4NEgvdgHPH9EbQ08TRvVFyqRvcbpTgTy1FmmyNbFJbyxG3IH0vgypHsNqFyaA4ONghUYryuxxk 0L1A7JonyQvpxnwQYUScT7WcZRpXVSyrb_MkdSCrXb.BixdnjLmj1qcRXlUR7j2MDAHNlyT4OA2j qJeDdDM722i1qtS9_pu2SIBpJFncPMVWhZYKbpCv3PcNZ9UAyj4QXjKlCQADZSbgoY4Ib6QfbInS 33ZVY3wrA.ujTqLdlWTiPdBTDnvUtgBVUX9nA9VbwaRF4XstHv6sqdDtrcgyniGlMVxU5OasIeY. V6Bg6bQkNuTb9s0p6W.Z_3C_HFLc8DRjuieM6TvG4x0vkPcTPxM5fzGJBWLilSjagYMPF.d8N2sy 6JiIJlOqmX2Ap7tlszQOKM4L8qhnHbrkQA0HBwcWy.DFK0rCjbMm2zl82jVhXyvJecqhM3Ipll_6 wYUYAL55F6XRfKuaED1FqGOSgqGUtlT7bug1GjD_D3uWNi0DIQ.dNoFJNLKI0rnDAL6QVQkROXqq RhRAabHpXnmIsRblqr_qVt8Z8pLCNlHfyRt3UL.FxfayjNBJOIIcxXhxC485u8QgCiIuCjjZ18uv it52ZgNJjbSHU0iSaGcc7SZiyLl7NYdv3xh1mtbo1Gtw0WqZ9DXe2jdoMijoT1cPPlkAut7p78S_ QYibRIt.ElKuAmPoutNPaHdZxvXCXkQOnD2NZWhnu9bOr4RTsc6QUdCwncUo7P7hXqOZHBWQq.W5 oTfZqizCk3FOZOtZxxNhO1JIYqMQ2YurIm_0xWQxhWFNHgFisaOoHuXGAFvvLgDlqNJFw9RcQ3IV 9sXJjbA6NQ7zkzVqB.Am36kNG1f49ooFovSPad8Akz7yIiGIuYGbfKMvK9qQ0DmNEhWkbYaeQuEo - Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ir2.yahoo.com with HTTP; Thu, 31 Dec 2020 14:01:09 +0000 Date: Thu, 31 Dec 2020 14:01:05 +0000 (UTC) To: "gdb-patches@sourceware.org" , Simon Marchi Message-ID: <1591238520.9132958.1609423265869@mail.yahoo.com> In-Reply-To: <52196aba-3452-5ff2-e2a0-14b0c554faa3@polymtl.ca> References: <20201229170227.821-1-ssbssa@yahoo.de> <20201229170227.821-4-ssbssa@yahoo.de> <52196aba-3452-5ff2-e2a0-14b0c554faa3@polymtl.ca> Subject: Re: [PATCH 4/4] Fix raw-frame-arguments in combination with frame-filters MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.17278 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Hannes Domani via Gdb-patches Reply-To: Hannes Domani Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Am Donnerstag, 31. Dezember 2020, 05:54:03 MEZ hat Simon Marchi Folgendes geschrieben: > On 2020-12-29 12:02 p.m., Hannes Domani via Gdb-patches wrote: > > Currently, if frame-filters are active, raw-values is used instead of > > raw-frame-arguments to decide if a pretty-printer should be invoked for > > frame arguments in a backtrace. > > > > This adds the PRINT_RAW_FRAME_ARGUMENTS flag to frame_filter_flag which= is > > then used in the frame-filter to override the raw flag in enumerate_arg= s. > > I'm not sure I understand the problem, but I have a small comment for the > test case: > > > diff --git a/gdb/testsuite/gdb.python/py-frame-args.exp b/gdb/testsuite= /gdb.python/py-frame-args.exp > > index fd9c1f4342..7c621e1302 100644 > > --- a/gdb/testsuite/gdb.python/py-frame-args.exp > > +++ b/gdb/testsuite/gdb.python/py-frame-args.exp > > @@ -34,6 +34,28 @@ gdb_test_no_output "source ${remote_python_file}" "l= oad python file" > >=C2=A0 gdb_breakpoint [gdb_get_line_number "break-here"] > >=C2=A0 gdb_continue_to_breakpoint "break-here" ".* break-here .*" > > > > +# Test raw-frame-arguments on backtrace with and without frame-filter > > +foreach filtered [list "enable" "disable"] { > > +=C2=A0=C2=A0=C2=A0 gdb_test_no_output "$filtered frame-filter global B= asicFrameFilter" > > + > > +=C2=A0=C2=A0=C2=A0 gdb_test "bt 1" \ > > +=C2=A0=C2=A0=C2=A0 ".*foo \\(x=3D42, ss=3Dsuper struct =3D {\[.\]{3}}\= \).*" \ > > +=C2=A0=C2=A0=C2=A0 "bt frame-filter=3D$filtered,pretty" > > + > > +=C2=A0=C2=A0=C2=A0 gdb_test "bt -raw-frame-arguments on 1" \ > > +=C2=A0=C2=A0=C2=A0 ".*foo \\(x=3D42, ss=3D\[.\]{3}\\).*" \ > > +=C2=A0=C2=A0=C2=A0 "bt frame-filter=3D$filtered,raw" > > + > > +=C2=A0=C2=A0=C2=A0 # "set print raw-values" should not affect frame ar= guments > > +=C2=A0=C2=A0=C2=A0 gdb_test_no_output "set print raw-values on" \ > > +=C2=A0=C2=A0=C2=A0 "raw-values-on,frame-filter=3D$filtered" > > +=C2=A0=C2=A0=C2=A0 gdb_test "bt 1" \ > > +=C2=A0=C2=A0=C2=A0 ".*foo \\(x=3D42, ss=3Dsuper struct =3D {\[.\]{3}}\= \).*" \ > > +=C2=A0=C2=A0=C2=A0 "bt frame-filter=3D$filtered,pretty,raw-values" > > +=C2=A0=C2=A0=C2=A0 gdb_test_no_output "set print raw-values off" \ > > +=C2=A0=C2=A0=C2=A0 "raw-values-off,frame-filter=3D$filtered" > > +} > > You can use foreach_with_prefix, that will ensure test names are > unique without having to include frame-filter=3D$filtered in each > test name.=C2=A0 Something like this: > > # Test raw-frame-arguments on backtrace with and without frame-filter > foreach_with_prefix filtered {enable disable} { >=C2=A0=C2=A0=C2=A0=C2=A0 gdb_test_no_output "$filtered frame-filter global= BasicFrameFilter" > >=C2=A0=C2=A0=C2=A0=C2=A0 gdb_test "bt 1" \ >=C2=A0=C2=A0=C2=A0=C2=A0 ".*foo \\(x=3D42, ss=3Dsuper struct =3D {\[.\]{3}= }\\).*" \ >=C2=A0=C2=A0=C2=A0=C2=A0 "bt pretty" > >=C2=A0=C2=A0=C2=A0=C2=A0 gdb_test "bt -raw-frame-arguments on 1" \ >=C2=A0=C2=A0=C2=A0=C2=A0 ".*foo \\(x=3D42, ss=3D\[.\]{3}\\).*" \ >=C2=A0=C2=A0=C2=A0=C2=A0 "bt raw" > >=C2=A0=C2=A0=C2=A0=C2=A0 # "set print raw-values" should not affect frame = arguments >=C2=A0=C2=A0=C2=A0=C2=A0 gdb_test_no_output "set print raw-values on" >=C2=A0=C2=A0=C2=A0=C2=A0 gdb_test "bt 1" \ >=C2=A0=C2=A0=C2=A0=C2=A0 ".*foo \\(x=3D42, ss=3Dsuper struct =3D {\[.\]{3}= }\\).*" \ >=C2=A0=C2=A0=C2=A0=C2=A0 "bt pretty,raw-values" > >=C2=A0=C2=A0=C2=A0=C2=A0 gdb_test_no_output "set print raw-values off" > } I've changed it locally like this, thanks. Hannes