From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-21901-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 12074 invoked by alias); 16 Jan 2003 17:27:36 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 12031 invoked from network); 16 Jan 2003 17:27:29 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 16 Jan 2003 17:27:29 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h0GGx5B12315
	for <gdb-patches@sources.redhat.com>; Thu, 16 Jan 2003 11:59:05 -0500
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h0GHRSa01728;
	Thu, 16 Jan 2003 12:27:28 -0500
Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46])
	by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h0GHRRM01164;
	Thu, 16 Jan 2003 12:27:27 -0500
Received: by localhost.redhat.com (Postfix, from userid 469)
	id 3AEB8FF79; Thu, 16 Jan 2003 12:31:48 -0500 (EST)
From: Elena Zannoni <ezannoni@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15910.60547.854681.600232@localhost.redhat.com>
Date: Thu, 16 Jan 2003 17:27:00 -0000
To: David Carlton <carlton@math.stanford.edu>
Cc: Fernando Nasser <fnasser@redhat.com>, Elena Zannoni <ezannoni@redhat.com>,
   gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Make tests more flexible
In-Reply-To: <ro1k7h558dc.fsf@jackfruit.Stanford.EDU>
References: <15910.5244.45739.864752@localhost.redhat.com>
	<3E26C44E.2050500@redhat.com>
	<ro1k7h558dc.fsf@jackfruit.Stanford.EDU>
X-SW-Source: 2003-01/txt/msg00616.txt.bz2

David Carlton writes:
 > On Thu, 16 Jan 2003 09:40:14 -0500, Fernando Nasser <fnasser@redhat.com> said:
 > 
 > > I see a few other files with the
 > 
 > > set srcfile ${srcdir}/${subdir}/${testfile}.c
 > 
 > > line.  They should be breaking runs with "different test tree
 > > configurations" as well.
 > 
 > > display.exp:set srcfile  ${srcdir}/${subdir}/${testfile}.c
 > > long_long.exp:set srcfile ${srcdir}/${subdir}/${testfile}.c
 > > mips_pro.exp:set srcfile ${srcdir}/$subdir/${testfile}.c
 > > overlays.exp:set srcfile ${srcdir}/${subdir}/${testfile}.c
 > > relocate.exp:set srcfile ${srcdir}/${subdir}/${testfile}.c
 > > setshow.exp:set srcfile ${srcdir}/${subdir}/${testfile}.c
 > > step-line.exp:set srcfile ${srcdir}/${subdir}/${testfile}.c
 > > step-test.exp:set srcfile ${srcdir}/${subdir}/${testfile}.c
 > 
 > For what it's worth, all those files pass for me.  But that doesn't
 > mean much; they might not use srcfile in ways that trigger this
 > particular bug, and one of them (overlays.exp) doesn't actually do
 > anything on my platform.  So we might as well convert them all to use
 > the proper definition of srcfile, it seems to me.
 > 

I just checked this, and all those files don't use the variable
srcfile except for the compilation line, 

if { [gdb_compile "${srcfile}" "${binfile}" executable {debug}] != "" } 

the problem that David uncovered was with the matching of ${srcfile}
in the output of a command, like for a breakpoint hit.  By defining
srcfile to be the long path name, instead of just the source fle name,
it was trying to match the wrong string when src==build tree.

Ok, so I am OK with changing all the above to be just 
set srcfile  ${testfile}.c

and

if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } 

I'll send a patch in a bit.

Elena


 > David Carlton
 > carlton@math.stanford.edu