From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20279 invoked by alias); 3 Jan 2003 22:46:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20271 invoked from network); 3 Jan 2003 22:46:35 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by 209.249.29.67 with SMTP; 3 Jan 2003 22:46:35 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h03MJ2B21165 for ; Fri, 3 Jan 2003 17:19:02 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h03MkNa22217; Fri, 3 Jan 2003 17:46:23 -0500 Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h03MkMl23963; Fri, 3 Jan 2003 17:46:22 -0500 Received: by localhost.redhat.com (Postfix, from userid 469) id 5D854FF79; Fri, 3 Jan 2003 17:50:46 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15894.5062.248207.219511@localhost.redhat.com> Date: Fri, 03 Jan 2003 22:46:00 -0000 To: Daniel Jacobowitz Cc: Andrew Cagney , Andreas Schwab , gdb-patches@sources.redhat.com Subject: Re: gdb --args mishandles empty arguments In-Reply-To: <20021203040105.GA19984@nevyn.them.org> References: <20021203022336.GA8725@nevyn.them.org> <3DEC1AE5.5080302@redhat.com> <20021203040105.GA19984@nevyn.them.org> X-SW-Source: 2003-01/txt/msg00110.txt.bz2 Daniel Jacobowitz writes: > On Mon, Dec 02, 2002 at 09:45:57PM -0500, Andrew Cagney wrote: > > >On Mon, Dec 02, 2002 at 03:42:18PM +0100, Andreas Schwab wrote: > > > > > >>With the intruduction of --args it is possible to construct empty > > >>arguments that need to be transformed to ''. > > >> > > >>Andreas. > > >> > > >>2002-12-02 Andreas Schwab > > >> > > >> * infcmd.c (construct_inferior_arguments): Handle empty arguments. > > > > > > > > >This patch is OK. > > > > > > btw, is there a test case? actually, is this tested at all? > > No, I don't think --args is... a test case if someone feels like > putting one together: > > gdb --args /bin/echo '' a > (gdb) run > > should produce '^ a$' Since I have a bug open against the current RH rawhide for this, I might as well create a test. How's this? (I'll send a formal RFA) ------args.c-------- #include int main (int argc, char **argv) { int i = 0; printf ("%d\n", argc); while (i < argc) printf ("%s\n", argv[i++]); return 0; } ------args.exp-------- # Copyright 2003 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or # (at your option) any later version. # # This program is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. # Please email any bugs, comments, and/or additions to this file to: # bug-gdb@prep.ai.mit.edu # This is a test for the gdb invocation option --args. if $tracelevel then { strace $tracelevel } global GDBFLAGS set testfile "args" set srcfile ${testfile}.c set binfile ${objdir}/${subdir}/${testfile} if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-w}] != "" } { gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail." } # # Test that the --args are processed correctly. # set GDBFLAGS "--args $binfile 1 3" gdb_exit gdb_start gdb_reinitialize_dir $srcdir/$subdir gdb_test "run" \ "Starting program.*args 1 3.*3\r\n.*args\r\n1\r\n3.*Program exited normally." \ "correct args printed" # # Test that the --args are processed correctly even if one of them is empty. # set GDBFLAGS "--args $binfile 1 '' 3" gdb_exit gdb_start gdb_reinitialize_dir $srcdir/$subdir gdb_test "run" \ "Starting program.*args 1 \\\\'\\\\' 3.*4\r\n.*args\r\n1\r\n''\r\n3.*Program exited normally." \ "correct args printed (one empty)" # # try with 2 empty args # set GDBFLAGS "--args $binfile 1 '' '' 3" gdb_exit gdb_start gdb_reinitialize_dir $srcdir/$subdir gdb_test "run" \ "Starting program.*args 1 \\\\'\\\\' \\\\'\\\\' 3.*5\r\n.*args\r\n1\r\n''\r\n''\r\n3.*Program exited normally." \ "correct args printed (two empty)"