From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25798 invoked by alias); 19 Dec 2002 23:41:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25781 invoked from network); 19 Dec 2002 23:41:57 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by 209.249.29.67 with SMTP; 19 Dec 2002 23:41:57 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gBJNFPg08592 for ; Thu, 19 Dec 2002 18:15:25 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gBJNfj217979 for ; Thu, 19 Dec 2002 18:41:45 -0500 Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gBJNfhL05476 for ; Thu, 19 Dec 2002 18:41:44 -0500 Received: by localhost.redhat.com (Postfix, from userid 469) id 9A95BFF79; Thu, 19 Dec 2002 18:46:08 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15874.23103.576384.830376@localhost.redhat.com> Date: Thu, 19 Dec 2002 15:51:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: Remove unnecessary zero-initializations In-Reply-To: <20021111042326.GA7554@nevyn.them.org> References: <20021111001910.GA17944@nevyn.them.org> <3DCF2D6E.2030407@redhat.com> <20021111042326.GA7554@nevyn.them.org> X-SW-Source: 2002-12/txt/msg00562.txt.bz2 [holiday mailbox cleaning...] Did you commit this? Elena Daniel Jacobowitz writes: > On Sun, Nov 10, 2002 at 11:09:18PM -0500, Andrew Cagney wrote: > > >Currently, thirteen files which provide a target_ops explicitly initialize > > >members they don't support to NULL. I plan to delete a number of these > > >methods, and rather than making sure I got all the necessary target files > > >each time I just wanted to delete the unnecessary lines up-front. All of > > >these are called-once functions initializing a statically or globally > > >declared object; C will guarantee zero-initialization for us. And several > > >of the functions explicitly called memset anyway. > > > > > >Besides, this way grepping for .to_require_attach\ = will only find targets > > >which define it to something useful. > > > > > >I'll commit this tomorrow unless someone sees a problem with it. > > > > > >Note1: remote-st.c hasn't been compilable in a while; m68*-tandem-* is > > >probably a good candidate for the hitlist. From a glance it looks like it > > >has been broken since the HP merge added the NULL assignments I'm removing, > > >which is about three years now I think. > > > > > >Note2: The DONT_USE member of struct target_ops can go now. > > > > The fact that 13 files were doing it should suggest that it was > > intentional. Might want to wait a bit longer while someone dregs up the > > history. > > Well, to me the fact that those thirteen files were doing it implies > it's a leftover. Look at them; the two win* one are cut-pasted from > inftarg.c; the others (except for sol-thread.c) are cut-pasted from > remote.c. And neither of those has the zeros. > > But it doesn't cost me anything to wait, except for slowing down the > progress on the fork patches :) I'll give it a few days. > > -- > Daniel Jacobowitz > MontaVista Software Debian GNU/Linux Developer