From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15012 invoked by alias); 9 Dec 2002 04:38:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15005 invoked from network); 9 Dec 2002 04:38:24 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 9 Dec 2002 04:38:24 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gB94CxP32307 for ; Sun, 8 Dec 2002 23:12:59 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gB94cOD29557 for ; Sun, 8 Dec 2002 23:38:24 -0500 Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gB94cNu14931 for ; Sun, 8 Dec 2002 23:38:23 -0500 Received: by localhost.redhat.com (Postfix, from userid 469) id 9568BFF79; Sun, 8 Dec 2002 23:34:02 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15860.7482.156282.685877@localhost.redhat.com> Date: Sun, 08 Dec 2002 20:42:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] fix -Werrors from new readline In-Reply-To: <20021209013830.GA27320@nevyn.them.org> References: <15859.59924.42114.329528@localhost.redhat.com> <15859.61596.274561.455522@localhost.redhat.com> <20021209013830.GA27320@nevyn.them.org> X-SW-Source: 2002-12/txt/msg00277.txt.bz2 Daniel Jacobowitz writes: > On Sun, Dec 08, 2002 at 08:23:40PM -0500, Elena Zannoni wrote: > > > > > > And the makefile. > > > > 2002-12-08 Elena Zannoni > > > > * Makefile.in (readline_h): Define. > > (completer.o): Depend on readline_h. > > (corelow.o): Ditto. > > (event-top.o): Ditto. > > (exec.o): Ditto. > > (solib.o): Ditto. > > (source.o): Ditto. > > (symfile.o): Ditto. > > (symmisc.o): Ditto. > > (top.o): Ditto. > > (tracepoint.o): Ditto. > > (utils.o): Ditto. > > (cli-dump.o): Ditto. > > (tui-hooks.o): Ditto. > > (tuiWin.o): Ditto. > > > +readline_h = $(READLINE_SRC)/readline.h > > Erk, is this necessary? It comes from the combined source tree, but > it's basically a 'system' header. I compile using the system readline > instead of the included one; this is just another thing which would get > in the way of doing that. > Hmm, but what happens if the system readline and gdb's readline get out of sync again? BTW, there was a readline_h already used in some tui files, but it wasn't defined. Rereading your sentence... you are trying to get rid of src/readline? > (The patches to do this are getting smaller; I'll finish and post them, > really I will!) > > -- > Daniel Jacobowitz > MontaVista Software Debian GNU/Linux Developer