From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-20461-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 20887 invoked by alias); 28 Nov 2002 16:48:47 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 20876 invoked from network); 28 Nov 2002 16:48:44 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 28 Nov 2002 16:48:44 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gASGOAP19513
	for <gdb-patches@sources.redhat.com>; Thu, 28 Nov 2002 11:24:10 -0500
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gASGmiD16157
	for <gdb-patches@sources.redhat.com>; Thu, 28 Nov 2002 11:48:44 -0500
Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46])
	by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gASGmgC02906;
	Thu, 28 Nov 2002 11:48:43 -0500
Received: by localhost.redhat.com (Postfix, from userid 469)
	id 13191FF79; Thu, 28 Nov 2002 11:44:26 -0500 (EST)
From: Elena Zannoni <ezannoni@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15846.18410.776134.585362@localhost.redhat.com>
Date: Thu, 28 Nov 2002 08:48:00 -0000
To: David Carlton <carlton@math.stanford.edu>
Cc: Elena Zannoni <ezannoni@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] mmalloc Makefile patch
In-Reply-To: <ro1adju93hl.fsf@jackfruit.Stanford.EDU>
References: <15841.30537.977839.406061@localhost.redhat.com>
	<ro1adju93hl.fsf@jackfruit.Stanford.EDU>
X-SW-Source: 2002-11/txt/msg00717.txt.bz2

David Carlton writes:
 > On Sun, 24 Nov 2002 20:05:13 -0500, Elena Zannoni <ezannoni@redhat.com> said:
 > 
 > > Turns out that the mmalloc.info file sufeered from the same problesm
 > > as the gdb info files.
 > 
 > > Elena
 > 
 > > 2002-11-24  Elena Zannoni  <ezannoni@redhat.com>
 > 
 > > 	* Makefile.in (INFO_DEPS): Define.
 > > 	(all): Add install-info to the rule.
 > 
 > Surely this should go in an 'install' target, not in 'all'?
 > 
 > David Carlton
 > carlton@math.stanford.edu


Oh dear! yes. Not clear what I was thinking.
thanks for catching it.

Here is a patch. Committed to mainline and 5.3 branch.

Elena


2002-11-28  Elena Zannoni  <ezannoni@redhat.com>

	* Makefile.in (install): Move install-info to here...
	(all): ...from here.



Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/mmalloc/Makefile.in,v
retrieving revision 1.4
diff -u -p -r1.4 Makefile.in
--- Makefile.in	26 Nov 2002 22:33:21 -0000	1.4
+++ Makefile.in	28 Nov 2002 16:42:52 -0000
@@ -97,7 +97,7 @@ TARGETOBJS =	mm.o
 
 STAGESTUFF =	$(TARGETLIB) *.o
 
-all:		$(TARGETLIB) install-info
+all:		$(TARGETLIB)
 
 info: $(INFO_DEPS)
 dvi: mmalloc.dvi
@@ -155,7 +155,7 @@ check: test1.c
 # for gdb, perhaps).
 #	./a.out
 
-install:	all
+install:	all install-info
 		$(INSTALL_DATA) $(TARGETLIB) $(libdir)/$(TARGETLIB)n
 		$(RANLIB) $(libdir)/$(TARGETLIB)n
 		mv -f $(libdir)/$(TARGETLIB)n $(libdir)/$(TARGETLIB)